From: Harald Welte <laforge@gnumonks.org>
To: Dan Carpenter <error27@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roel Kluin <roel.kluin@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pcmcia: fix error handling in cm4000_cs.c
Date: Sun, 18 Apr 2010 20:04:49 +0000 [thread overview]
Message-ID: <20100418200449.GA18200@prithivi.gnumonks.org> (raw)
In-Reply-To: <20100418190732.GA7920@bicker>
Hi Dan,
On Sun, Apr 18, 2010 at 10:07:33PM +0300, Dan Carpenter wrote:
> In the original code we used -ENODEV as the number of bytes to
> copy_to_user() and we didn't release the locks.
Thanks for pointing this out!
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Harald Welte <laforge@gnumonks.org>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
======================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
WARNING: multiple messages have this Message-ID (diff)
From: Harald Welte <laforge@gnumonks.org>
To: Dan Carpenter <error27@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roel Kluin <roel.kluin@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pcmcia: fix error handling in cm4000_cs.c
Date: Sun, 18 Apr 2010 22:04:49 +0200 [thread overview]
Message-ID: <20100418200449.GA18200@prithivi.gnumonks.org> (raw)
In-Reply-To: <20100418190732.GA7920@bicker>
Hi Dan,
On Sun, Apr 18, 2010 at 10:07:33PM +0300, Dan Carpenter wrote:
> In the original code we used -ENODEV as the number of bytes to
> copy_to_user() and we didn't release the locks.
Thanks for pointing this out!
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Harald Welte <laforge@gnumonks.org>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
next prev parent reply other threads:[~2010-04-18 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 19:07 [patch] pcmcia: fix error handling in cm4000_cs.c Dan Carpenter
2010-04-18 19:07 ` Dan Carpenter
2010-04-18 20:04 ` Harald Welte [this message]
2010-04-18 20:04 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100418200449.GA18200@prithivi.gnumonks.org \
--to=laforge@gnumonks.org \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.