From: Jens Axboe <jens.axboe@oracle.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MTD] Fix JFFS2 sync silent failure
Date: Mon, 19 Apr 2010 09:38:44 +0200 [thread overview]
Message-ID: <20100419073843.GN27497@kernel.dk> (raw)
In-Reply-To: <20100417184016.GA17345@logfs.org>
On Sat, Apr 17 2010, Jörn Engel wrote:
> Moin David,
>
> if I read the code correctly, JFFS2 will happily perform a NOP on
> sys_sync() again. And this time it appears to be Jens' fault.
>
> JFFS2 does not appear to set s_bdi anywhere. And as of 32a88aa1,
> __sync_filesystem() will return 0 if s_bdi is not set. As a result,
> sync_fs() is never called for jffs2 and whatever remains in the wbuf
> will not make it to the device.
>
> The patch also adds a BUG_ON to catch this problem in any remaining or
> future offenders. I am not sure about network filesystems, but at
> least bdev- and mtd-based ones should be caught.
>
> Opinions?
I think that BUG_ON() would be a lot better as a printk() and fail mount
instead. There's really little point in killing the kernel for something
you could easily warn about and recover nicely.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] [MTD] Fix JFFS2 sync silent failure
Date: Mon, 19 Apr 2010 09:38:44 +0200 [thread overview]
Message-ID: <20100419073843.GN27497@kernel.dk> (raw)
In-Reply-To: <20100417184016.GA17345@logfs.org>
On Sat, Apr 17 2010, Jörn Engel wrote:
> Moin David,
>
> if I read the code correctly, JFFS2 will happily perform a NOP on
> sys_sync() again. And this time it appears to be Jens' fault.
>
> JFFS2 does not appear to set s_bdi anywhere. And as of 32a88aa1,
> __sync_filesystem() will return 0 if s_bdi is not set. As a result,
> sync_fs() is never called for jffs2 and whatever remains in the wbuf
> will not make it to the device.
>
> The patch also adds a BUG_ON to catch this problem in any remaining or
> future offenders. I am not sure about network filesystems, but at
> least bdev- and mtd-based ones should be caught.
>
> Opinions?
I think that BUG_ON() would be a lot better as a printk() and fail mount
instead. There's really little point in killing the kernel for something
you could easily warn about and recover nicely.
--
Jens Axboe
next prev parent reply other threads:[~2010-04-19 7:38 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 18:40 [PATCH] [MTD] Fix JFFS2 sync silent failure Jörn Engel
2010-04-17 18:40 ` Jörn Engel
2010-04-19 7:38 ` Jens Axboe [this message]
2010-04-19 7:38 ` Jens Axboe
2010-04-19 10:15 ` Jörn Engel
2010-04-19 10:15 ` Jörn Engel
2010-04-19 10:20 ` Jens Axboe
2010-04-19 10:20 ` Jens Axboe
2010-04-19 11:39 ` Jörn Engel
2010-04-19 11:39 ` Jörn Engel
2010-04-22 5:54 ` Jörn Engel
2010-04-22 5:54 ` Jörn Engel
2010-04-22 6:26 ` Jörn Engel
2010-04-22 6:26 ` Jörn Engel
2010-04-22 14:25 ` Linus Torvalds
2010-04-22 14:25 ` Linus Torvalds
2010-04-22 14:33 ` Linus Torvalds
2010-04-22 14:33 ` Linus Torvalds
2010-04-22 16:27 ` Jens Axboe
2010-04-22 16:27 ` Jens Axboe
2010-04-22 20:33 ` [Patch] Catch filesystems lacking s_bdi Jörn Engel
2010-04-22 20:33 ` Jörn Engel
2010-04-23 10:05 ` Jens Axboe
2010-04-23 10:05 ` Jens Axboe
2010-04-23 20:55 ` Jörn Engel
2010-04-23 20:55 ` Jörn Engel
2010-04-26 9:48 ` Jens Axboe
2010-04-26 9:48 ` Jens Axboe
2010-04-26 14:32 ` Jörn Engel
2010-04-26 14:32 ` Jörn Engel
2010-04-26 14:38 ` Jens Axboe
2010-04-26 14:38 ` Jens Axboe
2010-04-26 14:45 ` Jens Axboe
2010-04-26 14:45 ` Jens Axboe
2010-04-26 16:30 ` [PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c Jörn Engel
2010-04-26 16:30 ` Jörn Engel
2010-04-26 16:31 ` [PATCH 2/2] [MTD] Call bdi_init() and bdi_register() Jörn Engel
2010-04-26 16:31 ` Jörn Engel
2010-04-26 17:02 ` Jens Axboe
2010-04-26 17:02 ` Jens Axboe
2010-04-26 17:12 ` Jörn Engel
2010-04-26 17:12 ` Jörn Engel
2010-04-27 7:52 ` Jens Axboe
2010-04-27 7:52 ` Jens Axboe
2010-04-27 8:11 ` Paolo Minazzi
2010-04-27 8:11 ` Paolo Minazzi
2010-04-27 8:16 ` Jens Axboe
2010-04-27 8:16 ` Jens Axboe
2010-04-27 11:29 ` Jörn Engel
2010-04-27 11:29 ` Jörn Engel
2010-04-27 11:33 ` Jens Axboe
2010-04-27 11:33 ` Jens Axboe
2010-04-27 9:01 ` Paolo Minazzi
2010-04-27 9:01 ` Paolo Minazzi
2010-04-27 9:16 ` Jens Axboe
2010-04-27 9:16 ` Jens Axboe
2010-04-27 9:26 ` Paolo Minazzi
2010-04-27 9:26 ` Paolo Minazzi
2010-04-27 9:29 ` Jens Axboe
2010-04-27 9:29 ` Jens Axboe
2010-04-27 9:36 ` Paolo Minazzi
2010-04-27 9:36 ` Paolo Minazzi
2010-04-27 11:17 ` Jörn Engel
2010-04-27 11:17 ` Jörn Engel
2010-04-27 11:31 ` Paolo Minazzi
2010-04-27 11:31 ` Paolo Minazzi
2010-04-27 11:40 ` Jörn Engel
2010-04-27 11:40 ` Jörn Engel
2010-04-27 11:48 ` [PATCH] [LogFS] Return -EINVAL if filesystem image doesn't match Jörn Engel
2010-04-27 11:48 ` Jörn Engel
2010-04-27 12:53 ` Paolo Minazzi
2010-04-27 12:53 ` Paolo Minazzi
2010-04-27 11:54 ` [PATCH 2/2] [MTD] Call bdi_init() and bdi_register() Paolo Minazzi
2010-04-27 11:54 ` Paolo Minazzi
2010-04-27 12:05 ` Jörn Engel
2010-04-27 12:05 ` Jörn Engel
2010-04-26 17:01 ` [PATCH 1/2] [MTD] Move mtd_bdi_*mappable to mtdcore.c Jens Axboe
2010-04-26 17:01 ` Jens Axboe
2010-04-26 17:08 ` Jörn Engel
2010-04-26 17:08 ` Jörn Engel
2010-04-26 17:10 ` Jens Axboe
2010-04-26 17:10 ` Jens Axboe
2010-04-22 9:03 ` [PATCH] [MTD] Fix JFFS2 sync silent failure Jens Axboe
2010-04-22 9:03 ` Jens Axboe
2010-04-22 10:39 ` Jens Axboe
2010-04-22 10:39 ` Jens Axboe
2010-04-22 10:58 ` David Woodhouse
2010-04-22 10:58 ` David Woodhouse
2010-04-22 11:05 ` Jens Axboe
2010-04-22 11:05 ` Jens Axboe
2010-04-22 11:55 ` Jörn Engel
2010-04-22 11:55 ` Jörn Engel
2010-04-22 12:08 ` Jens Axboe
2010-04-22 12:08 ` Jens Axboe
2010-04-22 12:17 ` Jörn Engel
2010-04-22 12:17 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419073843.GN27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.