* [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
@ 2010-04-20 8:32 Vitus Jensen
2010-04-20 16:12 ` Chris Larson
2010-04-20 16:15 ` Denys Dmytriyenko
0 siblings, 2 replies; 6+ messages in thread
From: Vitus Jensen @ 2010-04-20 8:32 UTC (permalink / raw)
To: Openembedded-devel; +Cc: Vitus Jensen
GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
isn't recommended but used by some programs, e.g. canutils.
Signed-off-by: Vitus Jensen <vjensen@gmx.de>
---
classes/base.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/base.bbclass b/classes/base.bbclass
index d3bfa76..e738693 100644
--- a/classes/base.bbclass
+++ b/classes/base.bbclass
@@ -310,7 +310,7 @@ base_do_configure() {
addtask compile after do_configure
do_compile[dirs] = "${S} ${B}"
base_do_compile() {
- if [ -e Makefile -o -e makefile ]; then
+ if [ -e Makefile -o -e makefile -o -e GNUmakefile ]; then
oe_runmake || die "make failed"
else
oenote "nothing to compile"
--
1.5.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
2010-04-20 8:32 [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile Vitus Jensen
@ 2010-04-20 16:12 ` Chris Larson
2010-04-20 16:15 ` Denys Dmytriyenko
1 sibling, 0 replies; 6+ messages in thread
From: Chris Larson @ 2010-04-20 16:12 UTC (permalink / raw)
To: openembedded-devel; +Cc: Vitus Jensen
On Tue, Apr 20, 2010 at 1:32 AM, Vitus Jensen <vjensen@gmx.de> wrote:
> GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
> isn't recommended but used by some programs, e.g. canutils.
>
> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
Acked-by: Chris Larson <chris_larson@mentor.com>
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
2010-04-20 8:32 [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile Vitus Jensen
2010-04-20 16:12 ` Chris Larson
@ 2010-04-20 16:15 ` Denys Dmytriyenko
2010-06-04 3:39 ` Vitus Jensen
1 sibling, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2010-04-20 16:15 UTC (permalink / raw)
To: openembedded-devel; +Cc: Vitus Jensen
On Tue, Apr 20, 2010 at 10:32:22AM +0200, Vitus Jensen wrote:
> GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
> isn't recommended but used by some programs, e.g. canutils.
>
> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
Acked-by: Denys Dmytriyenko <denis@denix.org>
> ---
> classes/base.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index d3bfa76..e738693 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -310,7 +310,7 @@ base_do_configure() {
> addtask compile after do_configure
> do_compile[dirs] = "${S} ${B}"
> base_do_compile() {
> - if [ -e Makefile -o -e makefile ]; then
> + if [ -e Makefile -o -e makefile -o -e GNUmakefile ]; then
> oe_runmake || die "make failed"
> else
> oenote "nothing to compile"
> --
> 1.5.6.5
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
2010-04-20 16:15 ` Denys Dmytriyenko
@ 2010-06-04 3:39 ` Vitus Jensen
2010-06-04 12:50 ` Cliff Brake
0 siblings, 1 reply; 6+ messages in thread
From: Vitus Jensen @ 2010-06-04 3:39 UTC (permalink / raw)
To: openembedded-devel
On Tue, 20 Apr 2010, Denys Dmytriyenko wrote:
> On Tue, Apr 20, 2010 at 10:32:22AM +0200, Vitus Jensen wrote:
>> GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
>> isn't recommended but used by some programs, e.g. canutils.
>>
>> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
>
> Acked-by: Denys Dmytriyenko <denis@denix.org>
Could someone please apply that patch? Now that it's acked by two
developers.
Thanks,
Vitus
>> ---
>> classes/base.bbclass | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/classes/base.bbclass b/classes/base.bbclass
>> index d3bfa76..e738693 100644
>> --- a/classes/base.bbclass
>> +++ b/classes/base.bbclass
>> @@ -310,7 +310,7 @@ base_do_configure() {
>> addtask compile after do_configure
>> do_compile[dirs] = "${S} ${B}"
>> base_do_compile() {
>> - if [ -e Makefile -o -e makefile ]; then
>> + if [ -e Makefile -o -e makefile -o -e GNUmakefile ]; then
>> oe_runmake || die "make failed"
>> else
>> oenote "nothing to compile"
>> --
>> 1.5.6.5
>>
>>
--
Vitus Jensen, Hannover, Germany, Universe (current)
pgp public key available from keyservers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
2010-06-04 3:39 ` Vitus Jensen
@ 2010-06-04 12:50 ` Cliff Brake
2010-07-20 9:05 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Cliff Brake @ 2010-06-04 12:50 UTC (permalink / raw)
To: openembedded-devel
On Thu, Jun 3, 2010 at 11:39 PM, Vitus Jensen <vjensen@gmx.de> wrote:
> On Tue, 20 Apr 2010, Denys Dmytriyenko wrote:
>
>> On Tue, Apr 20, 2010 at 10:32:22AM +0200, Vitus Jensen wrote:
>>>
>>> GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
>>> isn't recommended but used by some programs, e.g. canutils.
>>>
>>> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
>>
>> Acked-by: Denys Dmytriyenko <denis@denix.org>
>
> Could someone please apply that patch? Now that it's acked by two
> developers.
Applied, thanks!
Cliff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile
2010-06-04 12:50 ` Cliff Brake
@ 2010-07-20 9:05 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2010-07-20 9:05 UTC (permalink / raw)
To: openembedded-devel
On Fri, Jun 4, 2010 at 2:50 PM, Cliff Brake <cliff.brake@gmail.com> wrote:
> On Thu, Jun 3, 2010 at 11:39 PM, Vitus Jensen <vjensen@gmx.de> wrote:
>> On Tue, 20 Apr 2010, Denys Dmytriyenko wrote:
>>
>>> On Tue, Apr 20, 2010 at 10:32:22AM +0200, Vitus Jensen wrote:
>>>>
>>>> GNU make will look for GNUmakefile, makefile and Makefile. GNUmakefile
>>>> isn't recommended but used by some programs, e.g. canutils.
>>>>
>>>> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
>>>
>>> Acked-by: Denys Dmytriyenko <denis@denix.org>
>>
>> Could someone please apply that patch? Now that it's acked by two
>> developers.
>
> Applied, thanks!
Applied to org.openembedded.dev now. No idea where it was lost..
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-20 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-20 8:32 [PATCH] base.bbclass: base_do_compile() accepts GNUmakefile as Makefile Vitus Jensen
2010-04-20 16:12 ` Chris Larson
2010-04-20 16:15 ` Denys Dmytriyenko
2010-06-04 3:39 ` Vitus Jensen
2010-06-04 12:50 ` Cliff Brake
2010-07-20 9:05 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.