* [patch] nfs: testing for null instead of ERR_PTR()
@ 2010-04-21 10:35 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-04-21 10:35 UTC (permalink / raw)
To: Trond Myklebust
Cc: Chuck Lever, Benny Halevy, Al Viro, Andy Adamson, linux-nfs,
kernel-janitors
nfs_path() returns an ERR_PTR(), it doesn't return null.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index e016372..f9327bb 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2657,7 +2657,7 @@ static void nfs_fix_devname(const struct path *path, struct vfsmount *mnt)
devname = nfs_path(path->mnt->mnt_devname,
path->mnt->mnt_root, path->dentry,
page, PAGE_SIZE);
- if (devname = NULL)
+ if (IS_ERR(devname))
goto out_freepage;
tmp = kstrdup(devname, GFP_KERNEL);
if (tmp = NULL)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] nfs: testing for null instead of ERR_PTR()
@ 2010-04-21 10:35 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-04-21 10:35 UTC (permalink / raw)
To: Trond Myklebust
Cc: Chuck Lever, Benny Halevy, Al Viro, Andy Adamson, linux-nfs,
kernel-janitors
nfs_path() returns an ERR_PTR(), it doesn't return null.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index e016372..f9327bb 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2657,7 +2657,7 @@ static void nfs_fix_devname(const struct path *path, struct vfsmount *mnt)
devname = nfs_path(path->mnt->mnt_devname,
path->mnt->mnt_root, path->dentry,
page, PAGE_SIZE);
- if (devname == NULL)
+ if (IS_ERR(devname))
goto out_freepage;
tmp = kstrdup(devname, GFP_KERNEL);
if (tmp == NULL)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-21 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 10:35 [patch] nfs: testing for null instead of ERR_PTR() Dan Carpenter
2010-04-21 10:35 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.