From: Dan Carpenter <error27@gmail.com>
To: netdev@vger.kernel.org
Cc: Inaky Perez-Gonzalez <inaky@linux.intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
"David S. Miller" <davem@davemloft.net>,
wimax@linuxwimax.org, kernel-janitors@vger.kernel.org
Subject: [patch] wimax: checking ERR_PTR vs null
Date: Thu, 22 Apr 2010 09:50:10 +0000 [thread overview]
Message-ID: <20100422095010.GN29647@bicker> (raw)
stch_skb is allocated with wimax_gnl_re_state_change_alloc(). That
function returns ERR_PTRs on failure and doesn't return NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/wimax/stack.c b/net/wimax/stack.c
index 1ed65db..62b1a66 100644
--- a/net/wimax/stack.c
+++ b/net/wimax/stack.c
@@ -315,7 +315,7 @@ void __wimax_state_change(struct wimax_dev *wimax_dev, enum wimax_st new_state)
BUG();
}
__wimax_state_set(wimax_dev, new_state);
- if (stch_skb)
+ if (!IS_ERR(stch_skb))
wimax_gnl_re_state_change_send(wimax_dev, stch_skb, header);
out:
d_fnend(3, dev, "(wimax_dev %p new_state %u [old %u]) = void\n",
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: netdev@vger.kernel.org
Cc: Inaky Perez-Gonzalez <inaky@linux.intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
"David S. Miller" <davem@davemloft.net>,
wimax@linuxwimax.org, kernel-janitors@vger.kernel.org
Subject: [patch] wimax: checking ERR_PTR vs null
Date: Thu, 22 Apr 2010 11:50:10 +0200 [thread overview]
Message-ID: <20100422095010.GN29647@bicker> (raw)
stch_skb is allocated with wimax_gnl_re_state_change_alloc(). That
function returns ERR_PTRs on failure and doesn't return NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/wimax/stack.c b/net/wimax/stack.c
index 1ed65db..62b1a66 100644
--- a/net/wimax/stack.c
+++ b/net/wimax/stack.c
@@ -315,7 +315,7 @@ void __wimax_state_change(struct wimax_dev *wimax_dev, enum wimax_st new_state)
BUG();
}
__wimax_state_set(wimax_dev, new_state);
- if (stch_skb)
+ if (!IS_ERR(stch_skb))
wimax_gnl_re_state_change_send(wimax_dev, stch_skb, header);
out:
d_fnend(3, dev, "(wimax_dev %p new_state %u [old %u]) = void\n",
next reply other threads:[~2010-04-22 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:50 Dan Carpenter [this message]
2010-04-22 9:50 ` [patch] wimax: checking ERR_PTR vs null Dan Carpenter
2010-04-22 22:56 ` Inaky Perez-Gonzalez
2010-04-22 22:56 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422095010.GN29647@bicker \
--to=error27@gmail.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=inaky@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.