From: Greg KH <greg@kroah.com>
To: Dan Carpenter <error27@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alessio Igor Bogani <abogani@texware.it>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: testing the wrong variable in fs_create_by_name()
Date: Thu, 22 Apr 2010 16:24:20 +0000 [thread overview]
Message-ID: <20100422162420.GC30730@kroah.com> (raw)
In-Reply-To: <20100422100052.GT29647@bicker>
On Thu, Apr 22, 2010 at 12:00:52PM +0200, Dan Carpenter wrote:
> There is a typo here. We should be testing "*dentry" which was just
> assigned instead of "dentry". This could result in dereferencing an
> ERR_PTR inside either usbfs_mkdir() or usbfs_create().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice catch, thanks. I'll go queue this up.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Dan Carpenter <error27@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alessio Igor Bogani <abogani@texware.it>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: testing the wrong variable in fs_create_by_name()
Date: Thu, 22 Apr 2010 09:24:20 -0700 [thread overview]
Message-ID: <20100422162420.GC30730@kroah.com> (raw)
In-Reply-To: <20100422100052.GT29647@bicker>
On Thu, Apr 22, 2010 at 12:00:52PM +0200, Dan Carpenter wrote:
> There is a typo here. We should be testing "*dentry" which was just
> assigned instead of "dentry". This could result in dereferencing an
> ERR_PTR inside either usbfs_mkdir() or usbfs_create().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice catch, thanks. I'll go queue this up.
greg k-h
next prev parent reply other threads:[~2010-04-22 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 10:00 [patch] usb: testing the wrong variable in fs_create_by_name() Dan Carpenter
2010-04-22 10:00 ` Dan Carpenter
2010-04-22 16:24 ` Greg KH [this message]
2010-04-22 16:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422162420.GC30730@kroah.com \
--to=greg@kroah.com \
--cc=abogani@texware.it \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.