All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-pm@lists.linux-foundation.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: platform_bus: Allow runtime PM by default
Date: Thu, 22 Apr 2010 16:53:53 -0700	[thread overview]
Message-ID: <20100422235353.GA16310@kroah.com> (raw)
In-Reply-To: <1269625370-17754-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Fri, Mar 26, 2010 at 05:42:50PM +0000, Mark Brown wrote:
> 
> Currently the default runtime PM callbacks for platform devices return
> -ENOSYS, preventing the use of runtime PM platforms until they have
> provided at least a default implementation. This hinders the use of
> runtime PM by devices which work with many platforms such as memory
> mapped devices, MFDs and on chip IPs shared by multiple architectures.
> 
> Change the default implementation to the standard pm_generic_runtime
> one, allowing drivers to use runtime PM without per-architecture
> changes.

That's nice, but it breaks the build on my system:
  CC      drivers/base/platform.o
drivers/base/platform.c: In function ‘platform_pm_runtime_suspend’:
drivers/base/platform.c:970: error: implicit declaration of function ‘pm_generic_runtime_suspend’
drivers/base/platform.c: In function ‘platform_pm_runtime_resume’:
drivers/base/platform.c:975: error: implicit declaration of function ‘pm_generic_runtime_resume’
drivers/base/platform.c: In function ‘platform_pm_runtime_idle’:
drivers/base/platform.c:980: error: implicit declaration of function ‘pm_generic_runtime_idle’
make[1]: *** [drivers/base/platform.o] Error 1
make: *** [_module_drivers/base] Error 2

Care to fix it up?

thanks,

greg k-h
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/linux-pm

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-kernel@vger.kernel.org,
	linux-pm@lists.linux-foundation.org
Subject: Re: platform_bus: Allow runtime PM by default
Date: Thu, 22 Apr 2010 16:53:53 -0700	[thread overview]
Message-ID: <20100422235353.GA16310@kroah.com> (raw)
In-Reply-To: <1269625370-17754-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Fri, Mar 26, 2010 at 05:42:50PM +0000, Mark Brown wrote:
> 
> Currently the default runtime PM callbacks for platform devices return
> -ENOSYS, preventing the use of runtime PM platforms until they have
> provided at least a default implementation. This hinders the use of
> runtime PM by devices which work with many platforms such as memory
> mapped devices, MFDs and on chip IPs shared by multiple architectures.
> 
> Change the default implementation to the standard pm_generic_runtime
> one, allowing drivers to use runtime PM without per-architecture
> changes.

That's nice, but it breaks the build on my system:
  CC      drivers/base/platform.o
drivers/base/platform.c: In function ‘platform_pm_runtime_suspend’:
drivers/base/platform.c:970: error: implicit declaration of function ‘pm_generic_runtime_suspend’
drivers/base/platform.c: In function ‘platform_pm_runtime_resume’:
drivers/base/platform.c:975: error: implicit declaration of function ‘pm_generic_runtime_resume’
drivers/base/platform.c: In function ‘platform_pm_runtime_idle’:
drivers/base/platform.c:980: error: implicit declaration of function ‘pm_generic_runtime_idle’
make[1]: *** [drivers/base/platform.o] Error 1
make: *** [_module_drivers/base] Error 2

Care to fix it up?

thanks,

greg k-h

  parent reply	other threads:[~2010-04-22 23:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 17:42 [PATCH/RFC] platform_bus: Allow runtime PM by default Mark Brown
2010-03-26 22:35 ` Rafael J. Wysocki
2010-03-27 19:41   ` Mark Brown
2010-03-27 19:41   ` Mark Brown
2010-03-27 23:32     ` Rafael J. Wysocki
2010-03-27 23:32     ` Rafael J. Wysocki
2010-03-26 22:35 ` Rafael J. Wysocki
2010-04-22 23:53 ` Greg KH [this message]
2010-04-22 23:53   ` Greg KH
2010-04-23 10:57   ` Mark Brown
2010-04-23 10:57   ` Mark Brown
2010-04-23 15:05     ` Greg KH
2010-04-23 15:13       ` Mark Brown
2010-04-23 15:13         ` Mark Brown
2010-04-23 15:49         ` Greg KH
2010-04-23 15:49         ` Greg KH
2010-04-23 15:57       ` Mark Brown
2010-04-23 16:11         ` Greg KH
2010-04-23 16:11         ` Greg KH
2010-04-23 16:28           ` Mark Brown
2010-04-23 16:36             ` Greg KH
2010-04-23 16:36             ` Greg KH
2010-04-23 16:40             ` Rafael J. Wysocki
2010-04-23 16:40             ` Rafael J. Wysocki
2010-04-23 18:26               ` Rafael J. Wysocki
2010-04-23 18:41                 ` Rafael J. Wysocki
2010-05-07 13:27                   ` Mark Brown
2010-05-07 13:27                   ` Mark Brown
2010-05-07 14:20                     ` Jean Delvare
2010-05-10 21:10                       ` Rafael J. Wysocki
2010-05-10 21:10                       ` Rafael J. Wysocki
2010-05-11  6:19                         ` Jean Delvare
2010-05-11  6:19                         ` Jean Delvare
2010-05-11 13:00                           ` [linux-pm] " Mark Brown
2010-05-11 13:00                           ` Mark Brown
2010-05-07 14:20                     ` Jean Delvare
2010-04-23 18:41                 ` Rafael J. Wysocki
2010-04-23 18:26               ` Rafael J. Wysocki
2010-04-23 16:28           ` Mark Brown
2010-04-23 15:57       ` Mark Brown
2010-04-23 15:05     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100422235353.GA16310@kroah.com \
    --to=greg@kroah.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.