From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Éric Piel" <Eric.Piel@tremplin-utc.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed
Date: Fri, 23 Apr 2010 21:04:15 +0100 [thread overview]
Message-ID: <20100423200415.GA1009@srcf.ucam.org> (raw)
In-Reply-To: <4BD1FA5A.6060406@tremplin-utc.net>
On Fri, Apr 23, 2010 at 09:51:54PM +0200, Éric Piel wrote:
> Currently there are 2 modules which select ACPI_WMI and 4 which depend
> on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
> many which depend on it. Making usage of the select functionality all
> the time would avoid these inconsistencies.
Using select for ACPI_WMI is pretty clearly wrong since it fails in
cases where ACPI isn't enabled. But I don't think the appropriate way to
handle that is to encode the dependency between ACPI_WMI and ACPI
multiple times - they should just be switched to depend on it instead.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Éric Piel" <Eric.Piel@tremplin-utc.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed
Date: Fri, 23 Apr 2010 21:04:15 +0100 [thread overview]
Message-ID: <20100423200415.GA1009@srcf.ucam.org> (raw)
In-Reply-To: <4BD1FA5A.6060406@tremplin-utc.net>
On Fri, Apr 23, 2010 at 09:51:54PM +0200, Éric Piel wrote:
> Currently there are 2 modules which select ACPI_WMI and 4 which depend
> on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
> many which depend on it. Making usage of the select functionality all
> the time would avoid these inconsistencies.
Using select for ACPI_WMI is pretty clearly wrong since it fails in
cases where ACPI isn't enabled. But I don't think the appropriate way to
handle that is to encode the dependency between ACPI_WMI and ACPI
multiple times - they should just be switched to depend on it instead.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-04-23 20:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 0:23 [PATCH 1/2] Make WMI be selected automatically when needed Éric Piel
2010-04-17 0:23 ` Éric Piel
2010-04-17 0:31 ` Randy Dunlap
2010-04-17 0:31 ` Randy Dunlap
2010-04-17 0:58 ` Éric Piel
2010-04-17 0:58 ` Éric Piel
2010-04-23 19:20 ` Matthew Garrett
2010-04-23 19:20 ` Matthew Garrett
2010-04-23 19:51 ` Éric Piel
2010-04-23 19:51 ` Éric Piel
2010-04-23 20:04 ` Matthew Garrett [this message]
2010-04-23 20:04 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423200415.GA1009@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Eric.Piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.