All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: yuasa@linux-mips.org, Naren Sankar <nsankar@broadcom.com>,
	Jarod Wilson <jarod@wilsonet.com>,
	Scott Davilla <davilla@4pi.com>,
	Manu Abraham <abraham.manu@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 06/11] staging: crystalhd: clean up crystalhd_delete_cmd_context() return code
Date: Sun, 25 Apr 2010 22:40:41 +0900	[thread overview]
Message-ID: <20100425224041.293a0aac.yuasa@linux-mips.org> (raw)
In-Reply-To: <20100425221851.223dc284.yuasa@linux-mips.org>

Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
 drivers/staging/crystalhd/crystalhd_cmds.c |    4 +---
 drivers/staging/crystalhd/crystalhd_cmds.h |    2 +-
 drivers/staging/crystalhd/crystalhd_lnx.c  |    5 +----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
index 516e825..bfa11df 100644
--- a/drivers/staging/crystalhd/crystalhd_cmds.c
+++ b/drivers/staging/crystalhd/crystalhd_cmds.c
@@ -984,13 +984,11 @@ int __devinit crystalhd_setup_cmd_context(struct crystalhd_cmd *ctx,
  *
  * Called at the time of driver un-load.
  */
-BC_STATUS __devexit crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx)
+void __devexit crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx)
 {
 	BCMLOG(BCMLOG_DBG, "Deleting Command context..\n");
 
 	ctx->adp = NULL;
-
-	return BC_STS_SUCCESS;
 }
 
 /**
diff --git a/drivers/staging/crystalhd/crystalhd_cmds.h b/drivers/staging/crystalhd/crystalhd_cmds.h
index 90b4467..ea1b0d4 100644
--- a/drivers/staging/crystalhd/crystalhd_cmds.h
+++ b/drivers/staging/crystalhd/crystalhd_cmds.h
@@ -82,7 +82,7 @@ crystalhd_cmd_proc crystalhd_get_cmd_proc(struct crystalhd_cmd *ctx, uint32_t cm
 BC_STATUS crystalhd_user_open(struct crystalhd_cmd *ctx, struct crystalhd_user **user_ctx);
 BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc);
 int crystalhd_setup_cmd_context(struct crystalhd_cmd *ctx, struct crystalhd_adp *adp);
-BC_STATUS crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx);
+void crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx);
 bool crystalhd_cmd_interrupt(struct crystalhd_cmd *ctx);
 
 #endif
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index 490d2e0..19769df 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -512,7 +512,6 @@ static void __devexit chd_pci_release_mem(struct crystalhd_adp *pinfo)
 static void __devexit chd_dec_pci_remove(struct pci_dev *pdev)
 {
 	struct crystalhd_adp *pinfo;
-	BC_STATUS sts = BC_STS_SUCCESS;
 
 	BCMLOG_ENTER;
 
@@ -522,9 +521,7 @@ static void __devexit chd_dec_pci_remove(struct pci_dev *pdev)
 		return;
 	}
 
-	sts = crystalhd_delete_cmd_context(&pinfo->cmds);
-	if (sts != BC_STS_SUCCESS)
-		BCMLOG_ERR("cmd delete :%d \n", sts);
+	crystalhd_delete_cmd_context(&pinfo->cmds);
 
 	chd_dec_release_chdev(pinfo);
 
-- 
1.7.1


  parent reply	other threads:[~2010-04-25 13:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-25 13:18 [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Yoichi Yuasa
2010-04-25 13:21 ` [PATCH 02/11] staging: crystalhd: remove unused definitions in header files Yoichi Yuasa
2010-04-25 13:22 ` [PATCH 03/11] staging: crystalhd: remove unused BC_STATUS codes Yoichi Yuasa
2010-04-25 13:23 ` [PATCH 04/11] staging: crystalhd: mark all local functions static Yoichi Yuasa
2010-04-25 13:24 ` [PATCH 05/11] staging: crystalhd: clean up crystalhd_setup_cmd_context() return code Yoichi Yuasa
2010-04-25 13:40 ` Yoichi Yuasa [this message]
2010-04-25 13:41 ` [PATCH 07/11] staging: cyrstalhd: clean up crystalhd_user_close() " Yoichi Yuasa
2010-04-25 13:41 ` [PATCH 08/11] staging: crystalhd: clean up crystalhd_user_open() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 09/11] staging: crystalhd: clean up crystalhd_put_ddr2sleep() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 10/11] staging: crystalhd: remove unneeded crystalhd_put_in_reset() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 11/11] staging: crystalhd: remove unneeded crystalhd_stop_device() " Yoichi Yuasa
2010-04-29 19:09 ` [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Greg KH
2010-04-29 19:10 ` Greg KH
2010-04-30  0:40   ` Yoichi Yuasa
2010-04-30  1:41     ` Greg KH
2010-04-30  5:14       ` Yoichi Yuasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100425224041.293a0aac.yuasa@linux-mips.org \
    --to=yuasa@linux-mips.org \
    --cc=abraham.manu@gmail.com \
    --cc=davilla@4pi.com \
    --cc=greg@kroah.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsankar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.