From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: yuasa@linux-mips.org, Naren Sankar <nsankar@broadcom.com>,
Jarod Wilson <jarod@wilsonet.com>,
Scott Davilla <davilla@4pi.com>,
Manu Abraham <abraham.manu@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 10/11] staging: crystalhd: remove unneeded crystalhd_put_in_reset() return code
Date: Sun, 25 Apr 2010 22:42:34 +0900 [thread overview]
Message-ID: <20100425224234.a2f77b8f.yuasa@linux-mips.org> (raw)
In-Reply-To: <20100425221851.223dc284.yuasa@linux-mips.org>
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
drivers/staging/crystalhd/crystalhd_hw.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
index 4e4d271..ba81d01 100644
--- a/drivers/staging/crystalhd/crystalhd_hw.c
+++ b/drivers/staging/crystalhd/crystalhd_hw.c
@@ -119,7 +119,7 @@ static bool crystalhd_bring_out_of_rst(struct crystalhd_adp *adp)
return true;
}
-static bool crystalhd_put_in_reset(struct crystalhd_adp *adp)
+static void crystalhd_put_in_reset(struct crystalhd_adp *adp)
{
link_misc_perst_deco_ctrl rst_deco_cntrl;
link_misc_perst_clk_ctrl rst_clk_cntrl;
@@ -171,8 +171,6 @@ static bool crystalhd_put_in_reset(struct crystalhd_adp *adp)
/* restore the transaction configuration register */
crystalhd_reg_wr(adp, PCIE_TL_TRANSACTION_CONFIGURATION, temp);
-
- return true;
}
static void crystalhd_disable_interrupts(struct crystalhd_adp *adp)
@@ -332,8 +330,7 @@ static bool crystalhd_stop_device(struct crystalhd_adp *adp)
crystalhd_clear_errors(adp);
crystalhd_clear_interrupts(adp);
- if (!crystalhd_put_in_reset(adp))
- BCMLOG_ERR("Failed to Put Link To Reset State\n");
+ crystalhd_put_in_reset(adp);
reg = crystalhd_reg_rd(adp, PCIE_DLL_DATA_LINK_CONTROL);
reg |= ASPM_L1_ENABLE;
--
1.7.1
next prev parent reply other threads:[~2010-04-25 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 13:18 [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Yoichi Yuasa
2010-04-25 13:21 ` [PATCH 02/11] staging: crystalhd: remove unused definitions in header files Yoichi Yuasa
2010-04-25 13:22 ` [PATCH 03/11] staging: crystalhd: remove unused BC_STATUS codes Yoichi Yuasa
2010-04-25 13:23 ` [PATCH 04/11] staging: crystalhd: mark all local functions static Yoichi Yuasa
2010-04-25 13:24 ` [PATCH 05/11] staging: crystalhd: clean up crystalhd_setup_cmd_context() return code Yoichi Yuasa
2010-04-25 13:40 ` [PATCH 06/11] staging: crystalhd: clean up crystalhd_delete_cmd_context() " Yoichi Yuasa
2010-04-25 13:41 ` [PATCH 07/11] staging: cyrstalhd: clean up crystalhd_user_close() " Yoichi Yuasa
2010-04-25 13:41 ` [PATCH 08/11] staging: crystalhd: clean up crystalhd_user_open() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 09/11] staging: crystalhd: clean up crystalhd_put_ddr2sleep() " Yoichi Yuasa
2010-04-25 13:42 ` Yoichi Yuasa [this message]
2010-04-25 13:42 ` [PATCH 11/11] staging: crystalhd: remove unneeded crystalhd_stop_device() " Yoichi Yuasa
2010-04-29 19:09 ` [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Greg KH
2010-04-29 19:10 ` Greg KH
2010-04-30 0:40 ` Yoichi Yuasa
2010-04-30 1:41 ` Greg KH
2010-04-30 5:14 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425224234.a2f77b8f.yuasa@linux-mips.org \
--to=yuasa@linux-mips.org \
--cc=abraham.manu@gmail.com \
--cc=davilla@4pi.com \
--cc=greg@kroah.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsankar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.