From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH 01/10] OMAP1 clock: fix section mismatch on clk_init
Date: Mon, 26 Apr 2010 11:11:57 -0700 [thread overview]
Message-ID: <20100426181157.GF7225@atomide.com> (raw)
In-Reply-To: <20100426070420.9743.33754.stgit@localhost.localdomain>
* Paul Walmsley <paul@pwsan.com> [100426 00:03]:
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> remove the section annotation from omap1_clk_disable_unused()
> to kill the section mismatch warning.
In the long term this should be fixed properly.
The disable_unused is only called once with a late_initcall.
I'd rather not waste that memory keeping an __init function
around.
Regards,
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap1/clock.c | 2 +-
> arch/arm/mach-omap1/clock.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index e0aec10..6bbb1b8 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -578,7 +578,7 @@ int omap1_clk_set_rate(struct clk *clk, unsigned long rate)
>
> #ifdef CONFIG_OMAP_RESET_CLOCKS
>
> -void __init omap1_clk_disable_unused(struct clk *clk)
> +void omap1_clk_disable_unused(struct clk *clk)
> {
> __u32 regval32;
>
> diff --git a/arch/arm/mach-omap1/clock.h b/arch/arm/mach-omap1/clock.h
> index a4190af..75d0d7d 100644
> --- a/arch/arm/mach-omap1/clock.h
> +++ b/arch/arm/mach-omap1/clock.h
> @@ -39,7 +39,7 @@ extern long omap1_clk_round_rate_ckctl_arm(struct clk *clk, unsigned long rate);
> extern unsigned long omap1_watchdog_recalc(struct clk *clk);
>
> #ifdef CONFIG_OMAP_RESET_CLOCKS
> -extern void __init omap1_clk_disable_unused(struct clk *clk);
> +extern void omap1_clk_disable_unused(struct clk *clk);
> #else
> #define omap1_clk_disable_unused NULL
> #endif
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] OMAP1 clock: fix section mismatch on clk_init
Date: Mon, 26 Apr 2010 11:11:57 -0700 [thread overview]
Message-ID: <20100426181157.GF7225@atomide.com> (raw)
In-Reply-To: <20100426070420.9743.33754.stgit@localhost.localdomain>
* Paul Walmsley <paul@pwsan.com> [100426 00:03]:
> From: Felipe Balbi <felipe.balbi@nokia.com>
>
> remove the section annotation from omap1_clk_disable_unused()
> to kill the section mismatch warning.
In the long term this should be fixed properly.
The disable_unused is only called once with a late_initcall.
I'd rather not waste that memory keeping an __init function
around.
Regards,
Tony
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap1/clock.c | 2 +-
> arch/arm/mach-omap1/clock.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index e0aec10..6bbb1b8 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -578,7 +578,7 @@ int omap1_clk_set_rate(struct clk *clk, unsigned long rate)
>
> #ifdef CONFIG_OMAP_RESET_CLOCKS
>
> -void __init omap1_clk_disable_unused(struct clk *clk)
> +void omap1_clk_disable_unused(struct clk *clk)
> {
> __u32 regval32;
>
> diff --git a/arch/arm/mach-omap1/clock.h b/arch/arm/mach-omap1/clock.h
> index a4190af..75d0d7d 100644
> --- a/arch/arm/mach-omap1/clock.h
> +++ b/arch/arm/mach-omap1/clock.h
> @@ -39,7 +39,7 @@ extern long omap1_clk_round_rate_ckctl_arm(struct clk *clk, unsigned long rate);
> extern unsigned long omap1_watchdog_recalc(struct clk *clk);
>
> #ifdef CONFIG_OMAP_RESET_CLOCKS
> -extern void __init omap1_clk_disable_unused(struct clk *clk);
> +extern void omap1_clk_disable_unused(struct clk *clk);
> #else
> #define omap1_clk_disable_unused NULL
> #endif
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-26 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 7:04 [PATCH 00/10] OMAP PRCM, clock: some cleanup patches for 2.6.35 Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 01/10] OMAP1 clock: fix section mismatch on clk_init Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 18:11 ` Tony Lindgren [this message]
2010-04-26 18:11 ` Tony Lindgren
2010-04-26 7:04 ` [PATCH 02/10] OMAP2 PRCM: convert OMAP2 PRCM macros to the _SHIFT/_MASK suffixes Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 03/10] OMAP3 PRCM: convert OMAP3 " Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 04/10] OMAP2+ PRCM: convert remaining " Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 05/10] OMAP3: PM: PM_MPUGRPSEL writes should use GRPSEL macros, not EN macros Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 06/10] OMAP2+ clock: remove DEFAULT_RATE clksel_rate flag Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 07/10] OMAP2+ clock: clean up clkt_clksel.c Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 08/10] OMAP3 clock: rename RATE_IN_343X, RATE_IN_3430ES2 to match reality Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 09/10] OMAP3 clock: remove unnecessary duplicate of dpll4_m2_ck, added for 36xx Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
2010-04-26 7:04 ` [PATCH 10/10] OMAP clock: resolve old checkpatch and CodingStyle issues with plat-omap/clock.c Paul Walmsley
2010-04-26 7:04 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426181157.GF7225@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.