From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: 2.6.32.12: Build warning due to 78ce64a384 / missing in 2.6.33?
Date: Tue, 27 Apr 2010 09:17:33 +0300 [thread overview]
Message-ID: <20100427061733.GA10044@redhat.com> (raw)
In-Reply-To: <4BD5D34E.4080503@web.de>
On Mon, Apr 26, 2010 at 07:54:22PM +0200, Jan Kiszka wrote:
> Gleb,
>
> I'm getting a build warning with latest 2.6.32.12 due to "Fix segment
> descriptor loading". load_segment_descriptor_to_kvm_desct is unused
> after that patch. I assume it's just forgotten code and did not
> accidentally become unused, right?
>
Yes, the function was use only in one place and was removed by upstream
commit e01c2426149.
> The fact that 2.6.33.3 does not generate this makes me wonder why it
> obviously lacks the above patch. Not required or not yet queued?
>
Doesn't make much sense to include it in stable-32, but not stable-33. I
think stable-32 just has more attention since it is used by many
distribution as base kernel.
--
Gleb.
next prev parent reply other threads:[~2010-04-27 6:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 17:54 2.6.32.12: Build warning due to 78ce64a384 / missing in 2.6.33? Jan Kiszka
2010-04-27 6:17 ` Gleb Natapov [this message]
2010-04-27 7:41 ` Avi Kivity
2010-04-27 7:46 ` Gleb Natapov
2010-04-27 14:14 ` [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct Marcelo Tosatti
2010-04-27 14:43 ` Greg KH
2010-04-27 14:52 ` Gleb Natapov
2010-04-27 14:56 ` Greg KH
2010-04-27 16:16 ` Marcelo Tosatti
2010-04-27 16:22 ` Greg KH
2010-04-27 16:35 ` Marcelo Tosatti
2010-05-07 22:41 ` patch kvm-remove-unused-load_segment_descriptor_to_kvm_desct.patch added to 2.6.32-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427061733.GA10044@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.