All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Greg KH <gregkh@suse.de>
Cc: Gleb Natapov <gleb@redhat.com>,
	stable@kernel.org, Avi Kivity <avi@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>, kvm <kvm@vger.kernel.org>
Subject: [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct
Date: Tue, 27 Apr 2010 13:35:26 -0300	[thread overview]
Message-ID: <20100427163526.GA25766@amt.cnet> (raw)
In-Reply-To: <20100427162206.GA8668@suse.de>


Commit 78ce64a384 in v2.6.32.12 introduced a warning due to unused
load_segment_descriptor_to_kvm_desct helper, which has been opencoded by
this commit.

On upstream, the helper was removed as part of a different commit.

Remove the now unused function.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 389fc55..2782509 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4155,18 +4155,6 @@ static u16 get_segment_selector(struct kvm_vcpu *vcpu, int seg)
 	return kvm_seg.selector;
 }
 
-static int load_segment_descriptor_to_kvm_desct(struct kvm_vcpu *vcpu,
-						u16 selector,
-						struct kvm_segment *kvm_seg)
-{
-	struct desc_struct seg_desc;
-
-	if (load_guest_segment_descriptor(vcpu, selector, &seg_desc))
-		return 1;
-	seg_desct_to_kvm_desct(&seg_desc, selector, kvm_seg);
-	return 0;
-}
-
 static int kvm_load_realmode_segment(struct kvm_vcpu *vcpu, u16 selector, int seg)
 {
 	struct kvm_segment segvar = {

  reply	other threads:[~2010-04-27 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 17:54 2.6.32.12: Build warning due to 78ce64a384 / missing in 2.6.33? Jan Kiszka
2010-04-27  6:17 ` Gleb Natapov
2010-04-27  7:41   ` Avi Kivity
2010-04-27  7:46     ` Gleb Natapov
2010-04-27 14:14       ` [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct Marcelo Tosatti
2010-04-27 14:43         ` Greg KH
2010-04-27 14:52           ` Gleb Natapov
2010-04-27 14:56             ` Greg KH
2010-04-27 16:16               ` Marcelo Tosatti
2010-04-27 16:22                 ` Greg KH
2010-04-27 16:35                   ` Marcelo Tosatti [this message]
2010-05-07 22:41                     ` patch kvm-remove-unused-load_segment_descriptor_to_kvm_desct.patch added to 2.6.32-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427163526.GA25766@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=gregkh@suse.de \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.