From: Dan Carpenter <error27@gmail.com>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jani Nikula <ext-jani.1.nikula@nokia.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: potential null dereference
Date: Tue, 27 Apr 2010 10:30:51 +0000 [thread overview]
Message-ID: <20100427103051.GB29093@bicker> (raw)
In-Reply-To: <4BD6B13C.6020406@emlix.com>
On Tue, Apr 27, 2010 at 11:41:16AM +0200, Daniel Glöckner wrote:
> It returns a valid pointer iff (desc->flags & GPIO_TRIGGER_MASK).
>
> When !(desc->flags & GPIO_TRIGGER_MASK) it returns NULL and everything
> gets allocated (unless !gpio_flags as well). What you wanted to remove
> is the allocation code, not error handling code.
No no. I don't want to remove anything. I'm happy with the code as is
now that you've explained it to me. :)
regards,
dan carpenter
> It is always run when
> the trigger is set from "none" to something else.
>
> Daniel
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jani Nikula <ext-jani.1.nikula@nokia.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpio: potential null dereference
Date: Tue, 27 Apr 2010 12:30:51 +0200 [thread overview]
Message-ID: <20100427103051.GB29093@bicker> (raw)
In-Reply-To: <4BD6B13C.6020406@emlix.com>
On Tue, Apr 27, 2010 at 11:41:16AM +0200, Daniel Glöckner wrote:
> It returns a valid pointer iff (desc->flags & GPIO_TRIGGER_MASK).
>
> When !(desc->flags & GPIO_TRIGGER_MASK) it returns NULL and everything
> gets allocated (unless !gpio_flags as well). What you wanted to remove
> is the allocation code, not error handling code.
No no. I don't want to remove anything. I'm happy with the code as is
now that you've explained it to me. :)
regards,
dan carpenter
> It is always run when
> the trigger is set from "none" to something else.
>
> Daniel
>
next prev parent reply other threads:[~2010-04-27 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 19:25 [patch] gpio: potential null dereference Dan Carpenter
2010-04-26 19:25 ` Dan Carpenter
2010-04-26 23:05 ` Daniel Glöckner
2010-04-26 23:05 ` Daniel Glöckner
2010-04-26 23:14 ` Andrew Morton
2010-04-26 23:14 ` Andrew Morton
2010-04-27 9:05 ` Dan Carpenter
2010-04-27 9:05 ` Dan Carpenter
2010-04-27 9:41 ` Daniel Glöckner
2010-04-27 9:41 ` Daniel Glöckner
2010-04-27 10:30 ` Dan Carpenter [this message]
2010-04-27 10:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427103051.GB29093@bicker \
--to=error27@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dg@emlix.com \
--cc=ext-jani.1.nikula@nokia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.