From: Jamie Lokier <jamie@shareable.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: dedekind1@gmail.com, saeed.bishara@gmail.com,
Kevin Cernekee <cernekee@gmail.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
dwmw2@infradead.org
Subject: Re: [PATCHv2 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes
Date: Tue, 27 Apr 2010 14:47:37 +0100 [thread overview]
Message-ID: <20100427134737.GB25405@shareable.org> (raw)
In-Reply-To: <20100415025321.GB14954@pengutronix.de>
Wolfram Sang wrote:
> On Wed, Apr 14, 2010 at 05:57:33PM -0700, Kevin Cernekee wrote:
> > Ensure that the flash device is in a quiescent state before rebooting.
> > The implementation is closely modeled after the cfe_cmdset_0001 reboot
> > notifier, commit 963a6fb0a0d336d0513083b7e4b5c3ff9d6d2061 .
> >
> > Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
>
> Yes, if this is present for Intel, it should be present for AMD, IMHO.
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> Still, the correct solution is to wire the correct reset-line to the flashes.
> Above patch will not help if a watchdog kicks in. Been there :(
Isn't the patch intended to handle _software_ resets where the hard reset
line isn't toggled?
-- Jamie
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Lokier <jamie@shareable.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Kevin Cernekee <cernekee@gmail.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, saeed.bishara@gmail.com,
dedekind1@gmail.com
Subject: Re: [PATCHv2 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes
Date: Tue, 27 Apr 2010 14:47:37 +0100 [thread overview]
Message-ID: <20100427134737.GB25405@shareable.org> (raw)
In-Reply-To: <20100415025321.GB14954@pengutronix.de>
Wolfram Sang wrote:
> On Wed, Apr 14, 2010 at 05:57:33PM -0700, Kevin Cernekee wrote:
> > Ensure that the flash device is in a quiescent state before rebooting.
> > The implementation is closely modeled after the cfe_cmdset_0001 reboot
> > notifier, commit 963a6fb0a0d336d0513083b7e4b5c3ff9d6d2061 .
> >
> > Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
>
> Yes, if this is present for Intel, it should be present for AMD, IMHO.
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> Still, the correct solution is to wire the correct reset-line to the flashes.
> Above patch will not help if a watchdog kicks in. Been there :(
Isn't the patch intended to handle _software_ resets where the hard reset
line isn't toggled?
-- Jamie
next prev parent reply other threads:[~2010-04-27 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 20:30 [PATCH 0/2] MTD: Move reboot notifier from UBI to cfi_cmdset_0002 Kevin Cernekee
2010-04-13 20:30 ` Kevin Cernekee
2010-04-13 20:30 ` [PATCH 1/2] MTD: cfi_cmdset_0002: Add reboot notifier for AMD flashes Kevin Cernekee
2010-04-13 20:30 ` Kevin Cernekee
2010-04-14 4:57 ` Artem Bityutskiy
2010-04-14 4:57 ` Artem Bityutskiy
2010-04-14 5:33 ` Fabio Giovagnini
2010-04-14 5:33 ` Fabio Giovagnini
2010-04-15 0:57 ` [PATCHv2 " Kevin Cernekee
2010-04-15 0:57 ` Kevin Cernekee
2010-04-15 2:53 ` Wolfram Sang
2010-04-15 2:53 ` Wolfram Sang
2010-04-27 13:47 ` Jamie Lokier [this message]
2010-04-27 13:47 ` Jamie Lokier
2010-04-27 13:07 ` Artem Bityutskiy
2010-04-27 13:07 ` Artem Bityutskiy
2010-04-13 20:30 ` [PATCH 2/2] UBI: Remove reboot notifier Kevin Cernekee
2010-04-13 20:30 ` Kevin Cernekee
2010-04-27 13:25 ` Artem Bityutskiy
2010-04-27 13:25 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427134737.GB25405@shareable.org \
--to=jamie@shareable.org \
--cc=cernekee@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=saeed.bishara@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.