* linux-next: April 27 (mm/page-writeback) @ 2010-04-27 16:19 ` Randy Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2010-04-27 16:19 UTC (permalink / raw) To: Linux-Kernel; +Cc: linux-mm, akpm, Linux-Next When CONFIG_BLOCK is not enabled: mm/page-writeback.c:707: error: dereferencing pointer to incomplete type mm/page-writeback.c:708: error: dereferencing pointer to incomplete type --- ~Randy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: April 27 (mm/page-writeback) @ 2010-04-27 16:19 ` Randy Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2010-04-27 16:19 UTC (permalink / raw) To: Linux-Kernel; +Cc: linux-mm, akpm, Linux-Next When CONFIG_BLOCK is not enabled: mm/page-writeback.c:707: error: dereferencing pointer to incomplete type mm/page-writeback.c:708: error: dereferencing pointer to incomplete type --- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: April 27 (mm/page-writeback) 2010-04-27 16:19 ` Randy Dunlap @ 2010-04-27 18:08 ` Andrew Morton -1 siblings, 0 replies; 6+ messages in thread From: Andrew Morton @ 2010-04-27 18:08 UTC (permalink / raw) To: Randy Dunlap Cc: Linux-Kernel, linux-mm, Linux-Next, Matthew Garrett, Jens Axboe On Tue, 27 Apr 2010 09:19:30 -0700 (PDT) Randy Dunlap <randy.dunlap@oracle.com> wrote: > When CONFIG_BLOCK is not enabled: > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type > Subject: "laptop-mode: Make flushes per-device" fix From: Andrew Morton <akpm@linux-foundation.org> When CONFIG_BLOCK is not enabled: mm/page-writeback.c:707: error: dereferencing pointer to incomplete type mm/page-writeback.c:708: error: dereferencing pointer to incomplete type Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Matthew Garrett <mjg@redhat.com> Cc: Jens Axboe <jens.axboe@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- block/blk-core.c | 15 +++++++++++++++ include/linux/writeback.h | 1 - mm/page-writeback.c | 15 --------------- 3 files changed, 15 insertions(+), 16 deletions(-) diff -puN block/blk-core.c~laptop-mode-make-flushes-per-device-fix block/blk-core.c --- a/block/blk-core.c~laptop-mode-make-flushes-per-device-fix +++ a/block/blk-core.c @@ -488,6 +488,21 @@ struct request_queue *blk_alloc_queue(gf } EXPORT_SYMBOL(blk_alloc_queue); +static void laptop_mode_timer_fn(unsigned long data) +{ + struct request_queue *q = (struct request_queue *)data; + int nr_pages = global_page_state(NR_FILE_DIRTY) + + global_page_state(NR_UNSTABLE_NFS); + + /* + * We want to write everything out, not just down to the dirty + * threshold + */ + + if (bdi_has_dirty_io(&q->backing_dev_info)) + bdi_start_writeback(&q->backing_dev_info, NULL, nr_pages); +} + struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) { struct request_queue *q; diff -puN mm/page-writeback.c~laptop-mode-make-flushes-per-device-fix mm/page-writeback.c --- a/mm/page-writeback.c~laptop-mode-make-flushes-per-device-fix +++ a/mm/page-writeback.c @@ -693,21 +693,6 @@ int dirty_writeback_centisecs_handler(ct return 0; } -void laptop_mode_timer_fn(unsigned long data) -{ - struct request_queue *q = (struct request_queue *)data; - int nr_pages = global_page_state(NR_FILE_DIRTY) + - global_page_state(NR_UNSTABLE_NFS); - - /* - * We want to write everything out, not just down to the dirty - * threshold - */ - - if (bdi_has_dirty_io(&q->backing_dev_info)) - bdi_start_writeback(&q->backing_dev_info, NULL, nr_pages); -} - /* * We've spun up the disk and we're in laptop mode: schedule writeback * of all dirty data a few seconds from now. If the flush is already scheduled diff -puN include/linux/writeback.h~laptop-mode-make-flushes-per-device-fix include/linux/writeback.h --- a/include/linux/writeback.h~laptop-mode-make-flushes-per-device-fix +++ a/include/linux/writeback.h @@ -99,7 +99,6 @@ static inline void inode_sync_wait(struc void laptop_io_completion(struct backing_dev_info *info); void laptop_sync_completion(void); void laptop_mode_sync(struct work_struct *work); -void laptop_mode_timer_fn(unsigned long data); void throttle_vm_writeout(gfp_t gfp_mask); /* These are exported to sysctl. */ _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: April 27 (mm/page-writeback) @ 2010-04-27 18:08 ` Andrew Morton 0 siblings, 0 replies; 6+ messages in thread From: Andrew Morton @ 2010-04-27 18:08 UTC (permalink / raw) To: Randy Dunlap Cc: Linux-Kernel, linux-mm, Linux-Next, Matthew Garrett, Jens Axboe On Tue, 27 Apr 2010 09:19:30 -0700 (PDT) Randy Dunlap <randy.dunlap@oracle.com> wrote: > When CONFIG_BLOCK is not enabled: > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type > Subject: "laptop-mode: Make flushes per-device" fix From: Andrew Morton <akpm@linux-foundation.org> When CONFIG_BLOCK is not enabled: mm/page-writeback.c:707: error: dereferencing pointer to incomplete type mm/page-writeback.c:708: error: dereferencing pointer to incomplete type Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Matthew Garrett <mjg@redhat.com> Cc: Jens Axboe <jens.axboe@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> --- block/blk-core.c | 15 +++++++++++++++ include/linux/writeback.h | 1 - mm/page-writeback.c | 15 --------------- 3 files changed, 15 insertions(+), 16 deletions(-) diff -puN block/blk-core.c~laptop-mode-make-flushes-per-device-fix block/blk-core.c --- a/block/blk-core.c~laptop-mode-make-flushes-per-device-fix +++ a/block/blk-core.c @@ -488,6 +488,21 @@ struct request_queue *blk_alloc_queue(gf } EXPORT_SYMBOL(blk_alloc_queue); +static void laptop_mode_timer_fn(unsigned long data) +{ + struct request_queue *q = (struct request_queue *)data; + int nr_pages = global_page_state(NR_FILE_DIRTY) + + global_page_state(NR_UNSTABLE_NFS); + + /* + * We want to write everything out, not just down to the dirty + * threshold + */ + + if (bdi_has_dirty_io(&q->backing_dev_info)) + bdi_start_writeback(&q->backing_dev_info, NULL, nr_pages); +} + struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) { struct request_queue *q; diff -puN mm/page-writeback.c~laptop-mode-make-flushes-per-device-fix mm/page-writeback.c --- a/mm/page-writeback.c~laptop-mode-make-flushes-per-device-fix +++ a/mm/page-writeback.c @@ -693,21 +693,6 @@ int dirty_writeback_centisecs_handler(ct return 0; } -void laptop_mode_timer_fn(unsigned long data) -{ - struct request_queue *q = (struct request_queue *)data; - int nr_pages = global_page_state(NR_FILE_DIRTY) + - global_page_state(NR_UNSTABLE_NFS); - - /* - * We want to write everything out, not just down to the dirty - * threshold - */ - - if (bdi_has_dirty_io(&q->backing_dev_info)) - bdi_start_writeback(&q->backing_dev_info, NULL, nr_pages); -} - /* * We've spun up the disk and we're in laptop mode: schedule writeback * of all dirty data a few seconds from now. If the flush is already scheduled diff -puN include/linux/writeback.h~laptop-mode-make-flushes-per-device-fix include/linux/writeback.h --- a/include/linux/writeback.h~laptop-mode-make-flushes-per-device-fix +++ a/include/linux/writeback.h @@ -99,7 +99,6 @@ static inline void inode_sync_wait(struc void laptop_io_completion(struct backing_dev_info *info); void laptop_sync_completion(void); void laptop_mode_sync(struct work_struct *work); -void laptop_mode_timer_fn(unsigned long data); void throttle_vm_writeout(gfp_t gfp_mask); /* These are exported to sysctl. */ _ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: April 27 (mm/page-writeback) 2010-04-27 18:08 ` Andrew Morton @ 2010-04-27 18:13 ` Jens Axboe -1 siblings, 0 replies; 6+ messages in thread From: Jens Axboe @ 2010-04-27 18:13 UTC (permalink / raw) To: Andrew Morton Cc: Randy Dunlap, Linux-Kernel, linux-mm, Linux-Next, Matthew Garrett On Tue, Apr 27 2010, Andrew Morton wrote: > On Tue, 27 Apr 2010 09:19:30 -0700 (PDT) > Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > When CONFIG_BLOCK is not enabled: > > > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type > > > > Subject: "laptop-mode: Make flushes per-device" fix > From: Andrew Morton <akpm@linux-foundation.org> > > When CONFIG_BLOCK is not enabled: > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type Thanks Andrew, I've added this to the .35 branch. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: April 27 (mm/page-writeback) @ 2010-04-27 18:13 ` Jens Axboe 0 siblings, 0 replies; 6+ messages in thread From: Jens Axboe @ 2010-04-27 18:13 UTC (permalink / raw) To: Andrew Morton Cc: Randy Dunlap, Linux-Kernel, linux-mm, Linux-Next, Matthew Garrett On Tue, Apr 27 2010, Andrew Morton wrote: > On Tue, 27 Apr 2010 09:19:30 -0700 (PDT) > Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > When CONFIG_BLOCK is not enabled: > > > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type > > > > Subject: "laptop-mode: Make flushes per-device" fix > From: Andrew Morton <akpm@linux-foundation.org> > > When CONFIG_BLOCK is not enabled: > > mm/page-writeback.c:707: error: dereferencing pointer to incomplete type > mm/page-writeback.c:708: error: dereferencing pointer to incomplete type Thanks Andrew, I've added this to the .35 branch. -- Jens Axboe ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-27 18:13 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-04-27 16:19 linux-next: April 27 (mm/page-writeback) Randy Dunlap 2010-04-27 16:19 ` Randy Dunlap 2010-04-27 18:08 ` Andrew Morton 2010-04-27 18:08 ` Andrew Morton 2010-04-27 18:13 ` Jens Axboe 2010-04-27 18:13 ` Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.