All of lore.kernel.org
 help / color / mirror / Atom feed
From: "L. Alberto Giménez" <agimenez@sysvalve.es>
To: Dan Carpenter <error27@gmail.com>
Cc: Diego Giagio <diego@giagio.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipheth: potential null dereferences on error path
Date: Tue, 27 Apr 2010 21:43:47 +0000	[thread overview]
Message-ID: <20100427214347.GA2376@bart.evergreen.loc> (raw)
In-Reply-To: <20100427092012.GA29093@bicker>

On Tue, Apr 27, 2010 at 11:20:12AM +0200, Dan Carpenter wrote:
> The calls to usb_free_buffer() dereference rx_urb and tx_urb in the
> parameter list but those could be NULL.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: L. Alberto Giménez <agimenez@sysvalve.es>

-- 
L. Alberto Giménez
JabberID agimenez@jabber.sysvalve.es
GnuPG key ID 0x3BAABDE1
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "L. Alberto Giménez" <agimenez@sysvalve.es>
To: Dan Carpenter <error27@gmail.com>
Cc: Diego Giagio <diego@giagio.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipheth: potential null dereferences on error path
Date: Tue, 27 Apr 2010 23:43:47 +0200	[thread overview]
Message-ID: <20100427214347.GA2376@bart.evergreen.loc> (raw)
In-Reply-To: <20100427092012.GA29093@bicker>

On Tue, Apr 27, 2010 at 11:20:12AM +0200, Dan Carpenter wrote:
> The calls to usb_free_buffer() dereference rx_urb and tx_urb in the
> parameter list but those could be NULL.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: L. Alberto Giménez <agimenez@sysvalve.es>

-- 
L. Alberto Giménez
JabberID agimenez@jabber.sysvalve.es
GnuPG key ID 0x3BAABDE1

  parent reply	other threads:[~2010-04-27 21:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27  9:20 [patch] ipheth: potential null dereferences on error path Dan Carpenter
2010-04-27  9:20 ` Dan Carpenter
2010-04-27 21:00 ` L. Alberto Giménez
2010-04-27 21:00   ` L. Alberto Giménez
2010-04-27 21:33   ` David Miller
2010-04-27 21:33     ` David Miller
2010-04-27 21:43 ` L. Alberto Giménez [this message]
2010-04-27 21:43   ` L. Alberto Giménez
2010-04-27 21:49   ` David Miller
2010-04-27 21:49     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427214347.GA2376@bart.evergreen.loc \
    --to=agimenez@sysvalve.es \
    --cc=davem@davemloft.net \
    --cc=diego@giagio.com \
    --cc=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.