From: Pavel Machek <pavel@ucw.cz>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-pm@lists.linux-foundation.org,
Nigel Cunningham <ncunningham@crca.org.au>,
linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH 3/5] PM / Hibernate: separate block_io
Date: Wed, 28 Apr 2010 07:52:44 +0200 [thread overview]
Message-ID: <20100428055244.GA3501@ucw.cz> (raw)
In-Reply-To: <1272356118-10012-3-git-send-email-jslaby@suse.cz>
Hi!
> Move block I/O operations to a separate file. It is because it will
> be used later not only by the swap writer.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Nigel Cunningham <ncunningham@crca.org.au>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> +++ b/kernel/power/block_io.c
> @@ -0,0 +1,103 @@
> +/*
> + * This file provides functions for block I/O operations on swap/file.
> + *
> + * Copyright (C) 1998,2001-2005 Pavel Machek <pavel@suse.cz>
That address no longer works, but keeps popping up....
> diff --git a/kernel/power/power.h b/kernel/power/power.h
> index b1e207d..006270f 100644
> --- a/kernel/power/power.h
> +++ b/kernel/power/power.h
> @@ -142,6 +142,15 @@ extern int swsusp_read(unsigned int *flags_p);
> extern int swsusp_write(unsigned int flags);
> extern void swsusp_close(fmode_t);
>
> +/* kernel/power/block_io.c */
> +extern struct block_device *hib_resume_bdev;
It is slightly sad that this is now not only static, but also
cross-module...
> +extern int hib_bio_read_page(pgoff_t page_off, void *addr,
> + struct bio **bio_chain);
> +extern int hib_bio_write_page(pgoff_t page_off, void *addr,
> + struct bio **bio_chain);
> +extern int hib_wait_on_bio_chain(struct bio **bio_chain);
> +
Does the documentation usually go to the header in these cases?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Jiri Slaby <jslaby@suse.cz>
Cc: rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Nigel Cunningham <ncunningham@crca.org.au>
Subject: Re: [PATCH 3/5] PM / Hibernate: separate block_io
Date: Wed, 28 Apr 2010 07:52:44 +0200 [thread overview]
Message-ID: <20100428055244.GA3501@ucw.cz> (raw)
In-Reply-To: <1272356118-10012-3-git-send-email-jslaby@suse.cz>
Hi!
> Move block I/O operations to a separate file. It is because it will
> be used later not only by the swap writer.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Nigel Cunningham <ncunningham@crca.org.au>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> +++ b/kernel/power/block_io.c
> @@ -0,0 +1,103 @@
> +/*
> + * This file provides functions for block I/O operations on swap/file.
> + *
> + * Copyright (C) 1998,2001-2005 Pavel Machek <pavel@suse.cz>
That address no longer works, but keeps popping up....
> diff --git a/kernel/power/power.h b/kernel/power/power.h
> index b1e207d..006270f 100644
> --- a/kernel/power/power.h
> +++ b/kernel/power/power.h
> @@ -142,6 +142,15 @@ extern int swsusp_read(unsigned int *flags_p);
> extern int swsusp_write(unsigned int flags);
> extern void swsusp_close(fmode_t);
>
> +/* kernel/power/block_io.c */
> +extern struct block_device *hib_resume_bdev;
It is slightly sad that this is now not only static, but also
cross-module...
> +extern int hib_bio_read_page(pgoff_t page_off, void *addr,
> + struct bio **bio_chain);
> +extern int hib_bio_write_page(pgoff_t page_off, void *addr,
> + struct bio **bio_chain);
> +extern int hib_wait_on_bio_chain(struct bio **bio_chain);
> +
Does the documentation usually go to the header in these cases?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-04-28 5:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 8:15 [PATCH 1/5] FS: libfs, implement simple_write_to_buffer Jiri Slaby
2010-04-27 8:15 ` Jiri Slaby
2010-04-27 8:15 ` [PATCH 2/5] PM / Hibernate: snapshot cleanup Jiri Slaby
2010-04-27 8:15 ` Jiri Slaby
2010-04-28 5:52 ` Pavel Machek
2010-04-28 5:52 ` Pavel Machek
2010-04-27 8:15 ` [PATCH 3/5] PM / Hibernate: separate block_io Jiri Slaby
2010-04-27 8:15 ` Jiri Slaby
2010-04-28 5:52 ` Pavel Machek [this message]
2010-04-28 5:52 ` Pavel Machek
2010-04-29 6:22 ` Jiri Slaby
2010-04-29 6:22 ` Jiri Slaby
2010-04-27 8:15 ` [PATCH 4/5] PM / Hibernate: move the first_sector out of swsusp_write Jiri Slaby
2010-04-27 8:15 ` Jiri Slaby
2010-04-27 8:15 ` [PATCH 5/5] PM / Hibernate: group swap ops Jiri Slaby
2010-04-27 8:15 ` Jiri Slaby
2010-04-27 21:58 ` [PATCH 1/5] FS: libfs, implement simple_write_to_buffer Rafael J. Wysocki
2010-04-27 21:58 ` Rafael J. Wysocki
2010-04-28 22:16 ` Rafael J. Wysocki
2010-04-28 22:16 ` Rafael J. Wysocki
2010-05-01 22:00 ` Rafael J. Wysocki
2010-05-01 22:00 ` Rafael J. Wysocki
2010-04-28 22:10 ` Rafael J. Wysocki
2010-04-28 22:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428055244.GA3501@ucw.cz \
--to=pavel@ucw.cz \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=ncunningham@crca.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.