* [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check
@ 2010-04-29 9:58 Arnaud Patard
2010-04-29 16:35 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Arnaud Patard @ 2010-04-29 9:58 UTC (permalink / raw)
To: linux-mips
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
The check used to determine if uncached accelerated should be used or
not is wrong. The parenthesis are misplaced and making the test fail.
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_phys_mem_access_prot_check.patch --]
[-- Type: text/x-patch, Size: 537 bytes --]
Index: linux-2.6/arch/mips/loongson/common/mem.c
===================================================================
--- linux-2.6.orig/arch/mips/loongson/common/mem.c
+++ linux-2.6/arch/mips/loongson/common/mem.c
@@ -75,7 +75,7 @@ pgprot_t phys_mem_access_prot(struct fil
unsigned long end = offset + size;
if (__uncached_access(file, offset)) {
- if (((uca_start && offset) >= uca_start) &&
+ if (uca_start && (offset >= uca_start) &&
(end <= uca_end))
return __pgprot((pgprot_val(vma_prot) &
~_CACHE_MASK) |
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check
2010-04-29 9:58 [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check Arnaud Patard
@ 2010-04-29 16:35 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2010-04-29 16:35 UTC (permalink / raw)
To: Arnaud Patard; +Cc: linux-mips
On Thu, Apr 29, 2010 at 11:58:49AM +0200, Arnaud Patard wrote:
> The check used to determine if uncached accelerated should be used or
> not is wrong. The parenthesis are misplaced and making the test fail.
>
> Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-29 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-29 9:58 [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check Arnaud Patard
2010-04-29 16:35 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.