From: Mark Fasheh <mfasheh@suse.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: avoid direct write if we fall back to buffered v3
Date: Fri, 30 Apr 2010 13:37:53 -0700 [thread overview]
Message-ID: <20100430203753.GC24797@wotan.suse.de> (raw)
In-Reply-To: <20100426222423.GJ17377@mail.oracle.com>
On Mon, Apr 26, 2010 at 03:24:23PM -0700, Joel Becker wrote:
> On Sat, Apr 17, 2010 at 05:49:10PM +0800, Li Dongyang wrote:
> > when we fall back to buffered write from direct write, we call
> > __generic_file_aio_write but that will end up doing direct write
> > even we are only prepared to do buffered write because the file
> > has O_DIRECT flag set. This is a fix for
> > https://bugzilla.novell.com/show_bug.cgi?id=591039
> > revised with Joel's comments.
> >
> > Signed-off-by: Li Dongyang <lidongyang@novell.com>
>
> This looks good to me. I'd like Mark's ack before I push it to
> merge-window.
Looks good to me. Nice catch on the backing_dev_info bits.
Acked-by: Mark Fasheh <mfasheh@suse.com>
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2010-04-30 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 9:49 [Ocfs2-devel] [PATCH] ocfs2: avoid direct write if we fall back to buffered v3 Li Dongyang
2010-04-26 9:56 ` Li Dongyang
2010-04-26 22:24 ` Joel Becker
2010-04-30 20:37 ` Mark Fasheh [this message]
2010-04-30 20:47 ` Joel Becker
2010-04-30 20:52 ` Joel Becker
2010-05-04 1:37 ` Li Dongyang
2010-05-04 1:47 ` Joel Becker
2010-05-04 2:10 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430203753.GC24797@wotan.suse.de \
--to=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.