From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: avoid direct write if we fall back to buffered v3
Date: Mon, 3 May 2010 18:47:23 -0700 [thread overview]
Message-ID: <20100504014723.GB19213@mail.oracle.com> (raw)
In-Reply-To: <201005040937.49074.lidongyang@novell.com>
On Tue, May 04, 2010 at 09:37:48AM +0800, Li Dongyang wrote:
> On Saturday 01 May 2010 04:52:43 Joel Becker wrote:
> > On Fri, Apr 30, 2010 at 01:47:05PM -0700, Joel Becker wrote:
> > > Have you tested this version? I got a compile error:
> >
> > I want to be clear - has this patch (v3) been run against the
> > fsstress that caused the bug report in the first place? Does the
> > fsstress now pass? Let me know so I can send it upstream.
> >
> > Joel
> >
> it's a typo I made on my desktop, I first test it on my 2-node boxes, and it
> had already running fsstress for at least 70hrs(50 hrs with the
> OCFS2_INODE_SKIP_ORPHAN_DIR patches),
> then I checked out the ocfs2/master branch on my desktop in case of the
> differences between ocfs2/master and linus tree(like the block check in
> ocfs2_direct_IO_get_blocks). and made changes, then generated the patch, and a
> typo is made here, what a silly mistake!
And you are sure that the changes made by-hand on your desktop
are the same as made on your 2-node machines?
Joel
--
"I don't even butter my bread; I consider that cooking."
- Katherine Cebrian
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-05-04 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 9:49 [Ocfs2-devel] [PATCH] ocfs2: avoid direct write if we fall back to buffered v3 Li Dongyang
2010-04-26 9:56 ` Li Dongyang
2010-04-26 22:24 ` Joel Becker
2010-04-30 20:37 ` Mark Fasheh
2010-04-30 20:47 ` Joel Becker
2010-04-30 20:52 ` Joel Becker
2010-05-04 1:37 ` Li Dongyang
2010-05-04 1:47 ` Joel Becker [this message]
2010-05-04 2:10 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504014723.GB19213@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.