From: Michael Buesch <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>,
Larry Finger <larry.finger@lwfinger.net>
Subject: [PATCH] ssb: Implement fast powerup delay calculation
Date: Sat, 1 May 2010 19:19:42 +0200 [thread overview]
Message-ID: <201005011919.42294.mb@bu3sch.de> (raw)
In-Reply-To: <AANLkTimXBlIETHVLapuSrkI8uTIU8JPepLWvAEq6_D4T@mail.gmail.com>
On Saturday 01 May 2010 19:13:31 G?bor Stefanik wrote:
> 2010/5/1 Michael Buesch <mb@bu3sch.de>:
> > On Saturday 01 May 2010 18:29:06 G?bor Stefanik wrote:
> >> + ssb_write16(cc->dev, SSB_MMIO_POWERUP_DELAY, delay);
> >> }
> >>
> >> void ssb_chipco_suspend(struct ssb_chipcommon *cc)
> >> Index: wireless-testing/include/linux/ssb/ssb_regs.h
> >> ===================================================================
> >> --- wireless-testing.orig/include/linux/ssb/ssb_regs.h
> >> +++ wireless-testing/include/linux/ssb/ssb_regs.h
> >> @@ -26,6 +26,7 @@
> >> #define SSB_EUART (SSB_EXTIF_BASE + 0x00800000)
> >> #define SSB_LED (SSB_EXTIF_BASE + 0x00900000)
> >>
> >> +#define SSB_MMIO_POWERUP_DELAY 0x06A8
> >
> > I think you are really confusing something here.
> > That register is a wireless core register and we already write it in b43.
> >
> > --
> > Greetings, Michael.
> >
>
> This is what I am implementing: http://bcm-v4.sipsolutions.net/802.11/Init
> Here, it clearly says MMIO offset.
Yeah. Just what I said. It is an 802.11 core register.
We already write it in b43/main.c/b43_chip_init().
It is _wrong_ to write to the chipcommon at that offset.
--
Greetings, Michael.
WARNING: multiple messages have this Message-ID (diff)
From: Michael Buesch <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless" <linux-wireless@vger.kernel.org>,
"b43-dev" <b43-dev@lists.infradead.org>,
Larry Finger <larry.finger@lwfinger.net>
Subject: Re: [PATCH] ssb: Implement fast powerup delay calculation
Date: Sat, 1 May 2010 19:19:42 +0200 [thread overview]
Message-ID: <201005011919.42294.mb@bu3sch.de> (raw)
In-Reply-To: <AANLkTimXBlIETHVLapuSrkI8uTIU8JPepLWvAEq6_D4T@mail.gmail.com>
On Saturday 01 May 2010 19:13:31 Gábor Stefanik wrote:
> 2010/5/1 Michael Buesch <mb@bu3sch.de>:
> > On Saturday 01 May 2010 18:29:06 Gábor Stefanik wrote:
> >> + ssb_write16(cc->dev, SSB_MMIO_POWERUP_DELAY, delay);
> >> }
> >>
> >> void ssb_chipco_suspend(struct ssb_chipcommon *cc)
> >> Index: wireless-testing/include/linux/ssb/ssb_regs.h
> >> ===================================================================
> >> --- wireless-testing.orig/include/linux/ssb/ssb_regs.h
> >> +++ wireless-testing/include/linux/ssb/ssb_regs.h
> >> @@ -26,6 +26,7 @@
> >> #define SSB_EUART (SSB_EXTIF_BASE + 0x00800000)
> >> #define SSB_LED (SSB_EXTIF_BASE + 0x00900000)
> >>
> >> +#define SSB_MMIO_POWERUP_DELAY 0x06A8
> >
> > I think you are really confusing something here.
> > That register is a wireless core register and we already write it in b43.
> >
> > --
> > Greetings, Michael.
> >
>
> This is what I am implementing: http://bcm-v4.sipsolutions.net/802.11/Init
> Here, it clearly says MMIO offset.
Yeah. Just what I said. It is an 802.11 core register.
We already write it in b43/main.c/b43_chip_init().
It is _wrong_ to write to the chipcommon at that offset.
--
Greetings, Michael.
next prev parent reply other threads:[~2010-05-01 17:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 16:29 [PATCH] ssb: Implement fast powerup delay calculation Gábor Stefanik
2010-05-01 16:29 ` Gábor Stefanik
2010-05-01 16:32 ` Gábor Stefanik
2010-05-01 16:32 ` Gábor Stefanik
2010-05-01 17:07 ` Michael Buesch
2010-05-01 17:07 ` Michael Buesch
2010-05-01 17:13 ` Gábor Stefanik
2010-05-01 17:13 ` Gábor Stefanik
2010-05-01 17:19 ` Gábor Stefanik
2010-05-01 17:19 ` Gábor Stefanik
2010-05-01 17:19 ` Michael Buesch [this message]
2010-05-01 17:19 ` Michael Buesch
2010-05-01 17:42 ` Larry Finger
2010-05-01 17:42 ` Larry Finger
2010-05-01 17:48 ` Gábor Stefanik
2010-05-01 17:48 ` Gábor Stefanik
2010-05-01 18:15 ` Michael Buesch
2010-05-01 18:15 ` Michael Buesch
2010-05-01 18:27 ` Larry Finger
2010-05-01 18:27 ` Larry Finger
2010-05-01 18:40 ` Michael Buesch
2010-05-01 18:40 ` Michael Buesch
2010-05-01 18:43 ` Gábor Stefanik
2010-05-01 18:43 ` Gábor Stefanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005011919.42294.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.