linux-next: build warnings after merge of the driver-core.current tree

linux-next: build warnings after merge of the driver-core.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]

Hi Greg,

After merging the driver-core.current tree, today's linux-next build (powerpc
ppc64_defconfig and x86_64 allmodconfig) produced these warning:

drivers/pcmcia/ds.c: In function 'pcmcia_load_firmware':
drivers/pcmcia/ds.c:761: warning: passing argument 1 of 'release_firmware' discards qualifiers from pointer target type
include/linux/firmware.h:46: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
drivers/net/cxgb3/cxgb3_main.c: In function 't3_get_edc_fw':
drivers/net/cxgb3/cxgb3_main.c:1084: warning: passing argument 1 of 'release_firmware' discards qualifiers from pointer target type
include/linux/firmware.h:46: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'

and *lots* more similar warnings ...

Caused by commit d5ae47f7d90f94a15e668f389c12211a11798b6f
("firmware_class: fix memory leak - free allocated pages").  This patch
was modified from an earlier version that produced different (though many
fewer) warnings.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warnings after merge of the driver-core.current tree

[Greg KH]

On Mon, May 03, 2010 at 10:01:37AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the driver-core.current tree, today's linux-next build (powerpc
> ppc64_defconfig and x86_64 allmodconfig) produced these warning:
> 
> drivers/pcmcia/ds.c: In function 'pcmcia_load_firmware':
> drivers/pcmcia/ds.c:761: warning: passing argument 1 of 'release_firmware' discards qualifiers from pointer target type
> include/linux/firmware.h:46: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> drivers/net/cxgb3/cxgb3_main.c: In function 't3_get_edc_fw':
> drivers/net/cxgb3/cxgb3_main.c:1084: warning: passing argument 1 of 'release_firmware' discards qualifiers from pointer target type
> include/linux/firmware.h:46: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> 
> and *lots* more similar warnings ...
> 
> Caused by commit d5ae47f7d90f94a15e668f389c12211a11798b6f
> ("firmware_class: fix memory leak - free allocated pages").  This patch
> was modified from an earlier version that produced different (though many
> fewer) warnings.

Yeah, the people responsible were been notified last Friday, and they
sent me a patch today, hopefully it fixes the issue.  I'll test it out
tomorrow and merge it if it does.

thanks,

greg k-h

RE: linux-next: build warnings after merge of the driver-core.current tree

[Winkler, Tomas]

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Monday, May 03, 2010 3:02 AM
> To: Greg KH
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; David
> Woodhouse; Winkler, Tomas
> Subject: linux-next: build warnings after merge of the driver-core.current
> tree
> 
> Hi Greg,
> 
> After merging the driver-core.current tree, today's linux-next build
> (powerpc ppc64_defconfig and x86_64 allmodconfig) produced these warning:
>
> drivers/pcmcia/ds.c: In function 'pcmcia_load_firmware':
> drivers/pcmcia/ds.c:761: warning: passing argument 1 of 'release_firmware'
> discards qualifiers from pointer target type
> include/linux/firmware.h:46: note: expected 'struct firmware *' but argument
> is of type 'const struct firmware *'
> drivers/net/cxgb3/cxgb3_main.c: In function 't3_get_edc_fw':
> drivers/net/cxgb3/cxgb3_main.c:1084: warning: passing argument 1 of
> 'release_firmware' discards qualifiers from pointer target type
> include/linux/firmware.h:46: note: expected 'struct firmware *' but argument
> is of type 'const struct firmware *'
> 
> and *lots* more similar warnings ...
> 
> Caused by commit d5ae47f7d90f94a15e668f389c12211a11798b6f
> ("firmware_class: fix memory leak - free allocated pages").  This patch was
> modified from an earlier version that produced different (though many
> fewer) warnings.

Yesterday I posted the fixed version (v3) of this patch http://marc.info/?l=linux-kernel&m=127278850518085&w=2
Thanks
Tomas

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.