From: Anatolij Gustschin <agust@denx.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Detlev Zundel <dzu@denx.de>,
Markus Fischer <markus.fischer.ec@ifm.com>,
devicetree-discuss@lists.ozlabs.org,
Michael Weiss <michael.weiss@ifm.com>,
linuxppc-dev@ozlabs.org, Wolfgang Grandegger <wg@denx.de>
Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board
Date: Mon, 3 May 2010 11:22:08 +0200 [thread overview]
Message-ID: <20100503112208.1945893f@wker> (raw)
In-Reply-To: <g2tfa686aa41005020754t46934f13hbd5c75a6b7668a54@mail.gmail.com>
Hi Grant,
On Sun, 2 May 2010 08:54:26 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:
> Hi Anatolij,
>=20
> Comments below.
>=20
> On Fri, Apr 30, 2010 at 2:30 PM, Anatolij Gustschin <agust@denx.de> wrote:
> > Adds IFM PDM360NG device tree, and platform code.
...
> > + =A0 =A0 =A0 nfc@40000000 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mpc5121-nfc";
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x40000000 0x100000>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupts =3D <0x6 0x8>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupt-parent =3D <0x1>;
>=20
> This looks wrong. Shouldn't this be interrupt-parent =3D <&ipic>? In
> fact, if the root node has interrupt-parent =3D <&ipic> then the
> interrupt-parent property can be omitted from all other nodes unless
> they need to override it.
Yes, it should be interrupt-parent =3D <&ipic>. I will fix it, thanks.
...
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 // IPIC
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 // interrupts cell =3D <intr #, sense>
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 // sense values match linux IORESOURCE_IR=
Q_* defines:
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 // sense =3D=3D 8: Level, low assertion
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 // sense =3D=3D 2: Edge, high-to-low chan=
ge
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 //
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ipic: interrupt-controller@c00 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mpc51=
21-ipic", "fsl,ipic";
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 interrupt-controller;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <0>;
>=20
> Don't need #address-cells here
Ok, will remove.
...
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 mdio@2800 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mpc51=
21-fec-mdio";
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x2800 0x200>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <0>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phy: ethernet-phy@0 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <=
0x1f>;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_ty=
pe =3D "ethernet-phy";
>=20
> Remove device_type
Ok.
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 ethernet@2800 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "network";
>=20
> Ditto
Removing this property results in not functional ethernet,
in particular, the MAC address won't be set by U-Boot. I need
to add aliases node for ethernet0 to fix this. Ok, will remove
this device_type, too.
Thanks,
Anatolij
WARNING: multiple messages have this Message-ID (diff)
From: Anatolij Gustschin <agust@denx.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Detlev Zundel <dzu@denx.de>,
Markus Fischer <markus.fischer.ec@ifm.com>,
devicetree-discuss@lists.ozlabs.org,
Michael Weiss <michael.weiss@ifm.com>,
linuxppc-dev@ozlabs.org, Wolfgang Grandegger <wg@denx.de>
Subject: Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board
Date: Mon, 3 May 2010 11:22:08 +0200 [thread overview]
Message-ID: <20100503112208.1945893f@wker> (raw)
In-Reply-To: <g2tfa686aa41005020754t46934f13hbd5c75a6b7668a54@mail.gmail.com>
Hi Grant,
On Sun, 2 May 2010 08:54:26 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:
> Hi Anatolij,
>
> Comments below.
>
> On Fri, Apr 30, 2010 at 2:30 PM, Anatolij Gustschin <agust@denx.de> wrote:
> > Adds IFM PDM360NG device tree, and platform code.
...
> > + nfc@40000000 {
> > + compatible = "fsl,mpc5121-nfc";
> > + reg = <0x40000000 0x100000>;
> > + interrupts = <0x6 0x8>;
> > + interrupt-parent = <0x1>;
>
> This looks wrong. Shouldn't this be interrupt-parent = <&ipic>? In
> fact, if the root node has interrupt-parent = <&ipic> then the
> interrupt-parent property can be omitted from all other nodes unless
> they need to override it.
Yes, it should be interrupt-parent = <&ipic>. I will fix it, thanks.
...
> > + // IPIC
> > + // interrupts cell = <intr #, sense>
> > + // sense values match linux IORESOURCE_IRQ_* defines:
> > + // sense == 8: Level, low assertion
> > + // sense == 2: Edge, high-to-low change
> > + //
> > + ipic: interrupt-controller@c00 {
> > + compatible = "fsl,mpc5121-ipic", "fsl,ipic";
> > + interrupt-controller;
> > + #address-cells = <0>;
>
> Don't need #address-cells here
Ok, will remove.
...
> > + mdio@2800 {
> > + compatible = "fsl,mpc5121-fec-mdio";
> > + reg = <0x2800 0x200>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + phy: ethernet-phy@0 {
> > + reg = <0x1f>;
> > + device_type = "ethernet-phy";
>
> Remove device_type
Ok.
> > + ethernet@2800 {
> > + device_type = "network";
>
> Ditto
Removing this property results in not functional ethernet,
in particular, the MAC address won't be set by U-Boot. I need
to add aliases node for ethernet0 to fix this. Ok, will remove
this device_type, too.
Thanks,
Anatolij
next prev parent reply other threads:[~2010-05-03 9:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 20:30 [PATCH 1/2] powerpc/mpc512x: Group mpc512x board's selection menu Anatolij Gustschin
2010-04-30 20:30 ` [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board Anatolij Gustschin
2010-04-30 20:30 ` Anatolij Gustschin
2010-05-02 14:54 ` Grant Likely
2010-05-02 14:54 ` Grant Likely
2010-05-03 9:22 ` Anatolij Gustschin [this message]
2010-05-03 9:22 ` Anatolij Gustschin
2010-05-03 16:34 ` Scott Wood
2010-05-03 16:34 ` Scott Wood
2010-05-19 21:27 ` Grant Likely
2010-05-19 21:27 ` Grant Likely
2010-05-19 21:37 ` Scott Wood
2010-05-19 21:47 ` Grant Likely
2010-05-19 21:47 ` Grant Likely
2010-06-22 21:39 ` Scott Wood
2010-06-22 21:39 ` Scott Wood
2010-05-03 10:23 ` [PATCH v2 " Anatolij Gustschin
2010-05-03 10:23 ` Anatolij Gustschin
2010-07-23 13:49 ` [PATCH v3 " Anatolij Gustschin
2010-07-23 13:49 ` Anatolij Gustschin
2010-07-25 7:42 ` Grant Likely
2010-07-25 7:42 ` Grant Likely
2010-07-27 10:36 ` Anatolij Gustschin
2010-07-27 10:36 ` Anatolij Gustschin
2010-07-27 16:58 ` Grant Likely
2010-07-27 16:58 ` Grant Likely
2010-07-27 17:28 ` Anatolij Gustschin
2010-07-27 17:28 ` Anatolij Gustschin
2010-07-27 17:43 ` Grant Likely
2010-07-27 17:43 ` Grant Likely
2010-07-27 21:26 ` [PATCH v4 " Anatolij Gustschin
2010-07-27 21:26 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503112208.1945893f@wker \
--to=agust@denx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=markus.fischer.ec@ifm.com \
--cc=michael.weiss@ifm.com \
--cc=wg@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.