From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: enh@google.com, brian.haley@hp.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org
Subject: Re: linux kernel's IPV6_MULTICAST_HOPS default is 64; should be 1?
Date: Tue, 04 May 2010 00:57:57 -0700 (PDT) [thread overview]
Message-ID: <20100504.005757.97355845.davem@davemloft.net> (raw)
In-Reply-To: <OF8BB88147.4F3756DA-ON88257719.002A895A-88257719.002AEB08@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Tue, 4 May 2010 00:48:46 -0700
> It's set to -1 by default, but the common code for unicast and
> multicast in getsockopt is falling through to use the dst_entry.
>
> I believe (though I haven't actually tried it recently) it actually
> uses "1" for the default value for multicast;
It doesn't, all of the uses in the ipv6 stack say something like:
if (multicast)
hlimit = np->mcast_hops;
else
hlimit = np->hop_limit;
if (hlimit < 0)
hlimit = ip6_dst_hoplimit(dst);
Therefore, the change suggested by Elliot and which I committed is the
way to get the correct behavior and fix this.
next prev parent reply other threads:[~2010-05-04 7:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 1:33 linux kernel's IPV6_MULTICAST_HOPS default is 64; should be 1? enh
2010-05-04 2:16 ` Brian Haley
2010-05-04 3:58 ` enh
2010-05-04 6:05 ` David Miller
2010-05-04 6:19 ` enh
2010-05-04 6:22 ` David Miller
2010-05-04 6:27 ` enh
2010-05-04 6:42 ` David Miller
2010-05-04 7:48 ` David Stevens
2010-05-04 7:57 ` David Miller [this message]
2010-05-04 14:40 ` Brian Haley
2010-05-04 16:12 ` David Stevens
2010-05-04 16:43 ` Brian Haley
2010-05-04 17:05 ` David Stevens
2010-05-04 21:39 ` David Miller
2010-05-04 21:38 ` David Miller
2010-05-04 21:46 ` David Miller
2010-05-04 22:26 ` enh
2010-05-04 23:07 ` David Miller
2010-05-05 15:36 ` Brian Haley
2010-05-05 22:00 ` David Miller
2010-05-06 1:50 ` Brian Haley
2010-05-06 7:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504.005757.97355845.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=dlstevens@us.ibm.com \
--cc=enh@google.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.