From: Brian Haley <brian.haley@hp.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
enh@google.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org
Subject: Re: linux kernel's IPV6_MULTICAST_HOPS default is 64; should be 1?
Date: Tue, 04 May 2010 12:43:05 -0400 [thread overview]
Message-ID: <4BE04E99.2080903@hp.com> (raw)
In-Reply-To: <OFD462DFA3.FF279B8C-ON88257719.0057B1F8-88257719.005914D6@us.ibm.com>
David Stevens wrote:
> I think the original code was intending to do late binding -- carry "-1"
> as
> meaning "not set by user" and use the default value _at_the_time_of_
> _the_send_, and in its context. For that to have worked, the checks for
> "<0" in the send paths should've checked for multicast and used the
> multicast default as you're saying, Brian. And doing that not on the
> set, but when generating packets, is what I would've expected.
Right, we could do it that way, but then how far do we unravel the thread?
Unicast hoplimit is settable in the route, do we add a mcast_hops there
too, in addition to the per-interface tunable? I think just having it
the recommended default is good enough here, until someone shows they
have the need to do more.
> I don't see anything that's broken by changing it to use the default at
> the time of the set since for mcast the default is really a constant,
> and in fact, it looks like in addition to not actually using the default
> of 1,
> it was returning "-1" in the cmsg when not set by the user (and it, too,
> should've been "1", which it would return now).
>
> But if the default is different for each destination or interface in
> the multicast case (ie, by adding conf settings for mcast), then
> it really should do late binding and leave it as "-1" in the set, right?
> That's what I thought it was already doing, but apparently not;
> I think it used to, but maybe I just didn't notice.
Yes, that would be the ideal fix, and give the admin more control over
the value, but it seems like overkill to me. It's been 64 for a while,
and it's always been changeable by apps. I guess the only thing to
think about is there could be an app that works because it being 64
today, but will break tomorrow. Having a tunable parameter will let
you get the app working without re-writing it.
-Brian
next prev parent reply other threads:[~2010-05-04 16:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 1:33 linux kernel's IPV6_MULTICAST_HOPS default is 64; should be 1? enh
2010-05-04 2:16 ` Brian Haley
2010-05-04 3:58 ` enh
2010-05-04 6:05 ` David Miller
2010-05-04 6:19 ` enh
2010-05-04 6:22 ` David Miller
2010-05-04 6:27 ` enh
2010-05-04 6:42 ` David Miller
2010-05-04 7:48 ` David Stevens
2010-05-04 7:57 ` David Miller
2010-05-04 14:40 ` Brian Haley
2010-05-04 16:12 ` David Stevens
2010-05-04 16:43 ` Brian Haley [this message]
2010-05-04 17:05 ` David Stevens
2010-05-04 21:39 ` David Miller
2010-05-04 21:38 ` David Miller
2010-05-04 21:46 ` David Miller
2010-05-04 22:26 ` enh
2010-05-04 23:07 ` David Miller
2010-05-05 15:36 ` Brian Haley
2010-05-05 22:00 ` David Miller
2010-05-06 1:50 ` Brian Haley
2010-05-06 7:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE04E99.2080903@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=enh@google.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.