From: Tony Lindgren <tony@atomide.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Pais, Allen" <allen.pais@ti.com>
Subject: [PATCH 02b/11] omap2/3: Fix DEBUG_LL for omap zoom2/3
Date: Mon, 3 May 2010 17:58:38 -0700 [thread overview]
Message-ID: <20100504005838.GF29604@atomide.com> (raw)
In-Reply-To: <20100504004001.GB29604@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 108 bytes --]
And here's this patch one more time. Both 2a and 2b are needed
for zoom debug uart to work.
Regards,
Tony
[-- Attachment #2: omap3-zoom-debug-ll.patch --]
[-- Type: text/x-diff, Size: 4035 bytes --]
>From 1ed9c6a7dc9dea18ab1f5dd07ecec7e89ffa1ec5 Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Fri, 30 Apr 2010 12:57:14 -0700
Subject: [PATCH] omap2/3: Fix DEBUG_LL for omap zoom2/3
Zoom2 and 3 have UARTs only on the external debug board.
GPMC needs to be mapped early to use it for DEBUG_LL.
Additionally, 0xfb000000 overlaps with other areas, so
use 0xfa400000 for the virtual address instead.
Note that with the pending serial.c patches you need to
set console=ttyS0,115200n8 as it will be the only UART
mapped. To use DEBUG_LL, you need to pass also earlyprintk
in cmdline.
Cc: Allen Pais <allen.pais@ti.com>
Cc: Vikram Pandita <vikram.pandita@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
index e15d2e8..1d7f827 100644
--- a/arch/arm/mach-omap2/board-zoom-debugboard.c
+++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
@@ -82,7 +82,7 @@ static inline void __init zoom_init_smsc911x(void)
static struct plat_serial8250_port serial_platform_data[] = {
{
- .mapbase = 0x10000000,
+ .mapbase = ZOOM_UART_BASE,
.irq = OMAP_GPIO_IRQ(102),
.flags = UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
.irqflags = IRQF_SHARED | IRQF_TRIGGER_RISING,
diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
index 9a26f84..803ef14 100644
--- a/arch/arm/mach-omap2/board-zoom2.c
+++ b/arch/arm/mach-omap2/board-zoom2.c
@@ -91,8 +91,8 @@ static void __init omap_zoom2_map_io(void)
}
MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board")
- .phys_io = 0x48000000,
- .io_pg_offst = ((0xfa000000) >> 18) & 0xfffc,
+ .phys_io = ZOOM_UART_BASE,
+ .io_pg_offst = (ZOOM_UART_VIRT >> 18) & 0xfffc,
.boot_params = 0x80000100,
.map_io = omap_zoom2_map_io,
.init_irq = omap_zoom2_init_irq,
diff --git a/arch/arm/mach-omap2/board-zoom3.c b/arch/arm/mach-omap2/board-zoom3.c
index cd3e40c..3314704 100644
--- a/arch/arm/mach-omap2/board-zoom3.c
+++ b/arch/arm/mach-omap2/board-zoom3.c
@@ -73,8 +73,8 @@ static void __init omap_zoom_init(void)
}
MACHINE_START(OMAP_ZOOM3, "OMAP Zoom3 board")
- .phys_io = 0x48000000,
- .io_pg_offst = ((0xfa000000) >> 18) & 0xfffc,
+ .phys_io = ZOOM_UART_BASE,
+ .io_pg_offst = (ZOOM_UART_VIRT >> 18) & 0xfffc,
.boot_params = 0x80000100,
.map_io = omap_zoom_map_io,
.init_irq = omap_zoom_init_irq,
diff --git a/arch/arm/mach-omap2/include/mach/debug-macro.S b/arch/arm/mach-omap2/include/mach/debug-macro.S
index 4976169..35b2440 100644
--- a/arch/arm/mach-omap2/include/mach/debug-macro.S
+++ b/arch/arm/mach-omap2/include/mach/debug-macro.S
@@ -88,10 +88,10 @@ omap_uart_lsr: .word 0
b 98f
44: mov \rx, #UART_OFFSET(OMAP4_UART4_BASE)
b 98f
-95: mov \rx, #ZOOM_UART_BASE
+95: ldr \rx, =ZOOM_UART_BASE
ldr \tmp, =omap_uart_phys
str \rx, [\tmp, #0]
- mov \rx, #ZOOM_UART_VIRT
+ ldr \rx, =ZOOM_UART_VIRT
ldr \tmp, =omap_uart_virt
str \rx, [\tmp, #0]
mov \rx, #(UART_LSR << ZOOM_PORT_SHIFT)
diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
index 87f676a..3cfb425 100644
--- a/arch/arm/mach-omap2/io.c
+++ b/arch/arm/mach-omap2/io.c
@@ -166,6 +166,15 @@ static struct map_desc omap34xx_io_desc[] __initdata = {
.length = L4_EMU_34XX_SIZE,
.type = MT_DEVICE
},
+#if defined(CONFIG_DEBUG_LL) && \
+ (defined(CONFIG_MACH_OMAP_ZOOM2) || defined(CONFIG_MACH_OMAP_ZOOM3))
+ {
+ .virtual = ZOOM_UART_VIRT,
+ .pfn = __phys_to_pfn(ZOOM_UART_BASE),
+ .length = SZ_1M,
+ .type = MT_DEVICE
+ },
+#endif
};
#endif
#ifdef CONFIG_ARCH_OMAP4
diff --git a/arch/arm/plat-omap/include/plat/serial.h b/arch/arm/plat-omap/include/plat/serial.h
index 42a6318..19145f5 100644
--- a/arch/arm/plat-omap/include/plat/serial.h
+++ b/arch/arm/plat-omap/include/plat/serial.h
@@ -53,7 +53,7 @@
/* External port on Zoom2/3 */
#define ZOOM_UART_BASE 0x10000000
-#define ZOOM_UART_VIRT 0xfb000000
+#define ZOOM_UART_VIRT 0xfa400000
#define OMAP_PORT_SHIFT 2
#define OMAP7XX_PORT_SHIFT 0
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02b/11] omap2/3: Fix DEBUG_LL for omap zoom2/3
Date: Mon, 3 May 2010 17:58:38 -0700 [thread overview]
Message-ID: <20100504005838.GF29604@atomide.com> (raw)
In-Reply-To: <20100504004001.GB29604@atomide.com>
And here's this patch one more time. Both 2a and 2b are needed
for zoom debug uart to work.
Regards,
Tony
next prev parent reply other threads:[~2010-05-04 0:58 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 20:33 [PATCH 00/11] omap2/3/4: Multi-omap updates to boot test with omap3_defconfig Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 01/11] omap2/3/4: Fix multi.h when omap3 and omap4 are selected without omap2 Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 02/11] omap2/3: Fix DEBUG_LL for omap zoom2/3 Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:55 ` Kevin Hilman
2010-04-30 20:55 ` Kevin Hilman
2010-04-30 21:02 ` Tony Lindgren
2010-04-30 21:02 ` Tony Lindgren
2010-04-30 21:20 ` Kevin Hilman
2010-04-30 21:20 ` Kevin Hilman
2010-04-30 21:37 ` Pandita, Vikram
2010-04-30 21:37 ` Pandita, Vikram
2010-04-30 21:53 ` Pandita, Vikram
2010-04-30 21:53 ` Pandita, Vikram
2010-04-30 22:00 ` Kevin Hilman
2010-04-30 22:00 ` Kevin Hilman
2010-04-30 23:30 ` Tony Lindgren
2010-04-30 23:30 ` Tony Lindgren
2010-05-01 0:10 ` Kevin Hilman
2010-05-01 0:10 ` Kevin Hilman
2010-05-01 1:37 ` Tony Lindgren
2010-05-01 1:37 ` Tony Lindgren
2010-05-01 1:50 ` Tony Lindgren
2010-05-01 1:50 ` Tony Lindgren
2010-05-03 22:10 ` Pandita, Vikram
2010-05-03 22:10 ` Pandita, Vikram
2010-05-04 0:40 ` Tony Lindgren
2010-05-04 0:40 ` Tony Lindgren
2010-05-04 0:57 ` [PATCH 02a/11] omap: Use a memory address for storing the debug port info instead of UART1 scratchpad Tony Lindgren
2010-05-04 0:57 ` Tony Lindgren
2010-05-04 0:58 ` Tony Lindgren [this message]
2010-05-04 0:58 ` [PATCH 02b/11] omap2/3: Fix DEBUG_LL for omap zoom2/3 Tony Lindgren
2010-05-04 17:33 ` Pandita, Vikram
2010-05-04 17:33 ` Pandita, Vikram
2010-05-04 23:09 ` Tony Lindgren
2010-05-04 23:09 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 03/11] omap3: Fix compile for board-cm-t35 Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 04/11] omap3: Remove non-muxable ball entries for 3630 Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 05/11] omap4: Fix multiboot with CONFIG_PM and CONFIG_ARCH_OMAP3 selected Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-04-30 20:33 ` [PATCH 06/11] omap4: Fix omap_l2_cache_init not to run for other omaps Tony Lindgren
2010-04-30 20:33 ` Tony Lindgren
2010-05-01 6:18 ` Shilimkar, Santosh
2010-05-01 6:18 ` Shilimkar, Santosh
2010-05-01 17:46 ` Tony Lindgren
2010-05-01 17:46 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 07/11] omap2/3/4: Add new boards to omap3_defconfig Tony Lindgren
2010-04-30 20:34 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 08/11] omap2/3/4: Make omap3_defconfig usable on Nokia boards Tony Lindgren
2010-04-30 20:34 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 09/11] omap2/3/4: Update PMIC options for TWL and Menelaus chips Tony Lindgren
2010-04-30 20:34 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 10/11] omap2/3/4: Dissable CONFIG_PM_VERBOSE in omap3_defconfig Tony Lindgren
2010-04-30 20:34 ` Tony Lindgren
2010-04-30 20:34 ` [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP " Tony Lindgren
2010-04-30 20:34 ` Tony Lindgren
2010-04-30 20:50 ` Tony Lindgren
2010-04-30 20:50 ` Tony Lindgren
2010-05-04 0:52 ` Tony Lindgren
2010-05-04 0:52 ` Tony Lindgren
2010-05-04 7:26 ` Tomi Valkeinen
2010-05-04 7:26 ` Tomi Valkeinen
2010-05-04 14:40 ` Tony Lindgren
2010-05-04 14:40 ` Tony Lindgren
2010-05-04 14:50 ` Tomi Valkeinen
2010-05-04 14:50 ` Tomi Valkeinen
2010-05-04 19:23 ` Tony Lindgren
2010-05-04 19:23 ` Tony Lindgren
2010-05-05 17:32 ` Old DSS code broken as module (was "RE: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in omap3_defconfig") Aguirre, Sergio
2010-05-05 17:32 ` Aguirre, Sergio
2010-05-05 17:43 ` Tony Lindgren
2010-05-05 17:43 ` Tony Lindgren
2010-05-05 18:23 ` Aguirre, Sergio
2010-05-05 18:23 ` Aguirre, Sergio
2010-05-06 8:07 ` Tomi Valkeinen
2010-05-06 8:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504005838.GF29604@atomide.com \
--to=tony@atomide.com \
--cc=allen.pais@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.