From: Dan Carpenter <error27@gmail.com>
To: jarod@redhat.com
Cc: linux-media@vger.kernel.org
Subject: [-next] [bug report] media/IR/imon: array overflow
Date: Tue, 4 May 2010 14:20:30 +0200 [thread overview]
Message-ID: <20100504122030.GX29093@bicker> (raw)
This is a Smatch thing. I'm not sure what's intended.
drivers/media/IR/imon.c +1211 imon_panel_key_lookup(10) error: buffer overflow 'imon_panel_key_table' 21 <= 21
1207 for (i = 0; i < ARRAY_SIZE(imon_panel_key_table); i++)
1208 if (imon_panel_key_table[i].hw_code == (code | 0xffee))
1209 break;
After the for loop i can be 0 to 21.
1210
1211 keycode = imon_panel_key_table[i % IMON_KEY_RELEASE_OFFSET].keycode;
IMON_KEY_RELEASE_OFFSET is 1000 so it doesn't affect anything.
regards,
dan carpenter
next reply other threads:[~2010-05-04 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 12:20 Dan Carpenter [this message]
2010-05-04 14:03 ` [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET Jarod Wilson
2010-05-04 16:06 ` Dan Carpenter
2010-05-04 19:17 ` [PATCH v2] " Jarod Wilson
2010-05-07 11:52 ` Mauro Carvalho Chehab
2010-05-07 13:13 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504122030.GX29093@bicker \
--to=error27@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.