All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET
Date: Tue, 4 May 2010 10:03:18 -0400	[thread overview]
Message-ID: <20100504140318.GA10813@redhat.com> (raw)
In-Reply-To: <20100504122030.GX29093@bicker>

This hack was used when the imon driver was using internal key lookup
routines, but became dead weight when the driver was converted to use
ir-core's key lookup routines. These bits simply didn't get removed,
drop 'em now.

Pointed out by Dan Carpenter.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 drivers/media/IR/imon.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c
index 27743eb..bce8ef8 100644
--- a/drivers/media/IR/imon.c
+++ b/drivers/media/IR/imon.c
@@ -55,7 +55,6 @@
 #define BIT_DURATION	250	/* each bit received is 250us */
 
 #define IMON_CLOCK_ENABLE_PACKETS	2
-#define IMON_KEY_RELEASE_OFFSET		1000
 
 /*** P R O T O T Y P E S ***/
 
@@ -1205,7 +1204,7 @@ static u32 imon_panel_key_lookup(u64 hw_code)
 		if (imon_panel_key_table[i].hw_code == (code | 0xffee))
 			break;
 
-	keycode = imon_panel_key_table[i % IMON_KEY_RELEASE_OFFSET].keycode;
+	keycode = imon_panel_key_table[i].keycode;
 
 	return keycode;
 }

-- 
Jarod Wilson
jarod@redhat.com


  reply	other threads:[~2010-05-04 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 12:20 [-next] [bug report] media/IR/imon: array overflow Dan Carpenter
2010-05-04 14:03 ` Jarod Wilson [this message]
2010-05-04 16:06   ` [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET Dan Carpenter
2010-05-04 19:17     ` [PATCH v2] " Jarod Wilson
2010-05-07 11:52       ` Mauro Carvalho Chehab
2010-05-07 13:13         ` Jarod Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100504140318.GA10813@redhat.com \
    --to=jarod@redhat.com \
    --cc=error27@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.