* [patch -next] input: unlock on error paths
@ 2010-05-05 5:56 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-05-05 5:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media
We can't return here directly, we need to unlock the event_lock first.
This was introduced in: edeada2cde "V4L/DVB: input: Add support for
EVIO[CS]GKEYCODEBIG"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/input/input.c b/drivers/input/input.c
index e623edf..7c3fc5e 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -759,8 +759,9 @@ int input_set_keycode_big(struct input_dev *dev,
if (!dev->setkeycode)
goto out;
- if (input_fetch_scancode(kt_entry, &scancode))
- return -EINVAL;
+ retval = input_fetch_scancode(kt_entry, &scancode);
+ if (retval)
+ goto out;
retval = dev->getkeycode(dev, scancode,
&old_keycode);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-05 5:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-05 5:56 [patch -next] input: unlock on error paths Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.