* [patch -next] media/mem2mem: dereferencing free memory
@ 2010-05-05 5:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-05-05 5:58 UTC (permalink / raw)
To: linux-media; +Cc: Mauro Carvalho Chehab
We dereferenced "ctx" on the error path.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c
index baf211b..b161d26 100644
--- a/drivers/media/video/mem2mem_testdev.c
+++ b/drivers/media/video/mem2mem_testdev.c
@@ -871,8 +871,10 @@ static int m2mtest_open(struct file *file)
ctx->m2m_ctx = v4l2_m2m_ctx_init(ctx, dev->m2m_dev, queue_init);
if (IS_ERR(ctx->m2m_ctx)) {
+ int ret = PTR_ERR(ctx->m2m_ctx);
+
kfree(ctx);
- return PTR_ERR(ctx->m2m_ctx);
+ return ret;
}
atomic_inc(&dev->num_inst);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-05 5:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-05 5:58 [patch -next] media/mem2mem: dereferencing free memory Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.