All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven King <sfking@fdwdc.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature
Date: Wed, 05 May 2010 15:31:55 +0000	[thread overview]
Message-ID: <201005050831.56526.sfking@fdwdc.com> (raw)
In-Reply-To: <20100504113655.42623e51@hyperion.delvare>

On Tuesday 04 May 2010 2:36:55 Jean Delvare wrote:
> Steven,
>
> On Sat, 3 Apr 2010 09:23:40 +0200, Jean Delvare wrote:
> > On Mon, 15 Mar 2010 13:52:17 +0100, Jean Delvare wrote:
> > > Here's my review. Feel free to pick whatever you like in it and ignore
> > > the rest. Then submit a final version for upstream integration.
> >
> > Any update? Would be great to not lose all the work that both you and
> > me put in this driver so far.
>
> If you do not reply, I will do all the suggested changes myself and
> push the driver upstream.

I'm in the midst of the old '12 hours a day 'til we get this thing off to 
manufacturing' so I havent had time to do more than a cursory look at your 
changes and probably wont for a while longer.  Other than a few minor style 
issues, I didnt see anything I'd take issue with, so if thats what you think is 
the right thing to do, then please do.

-- 
Steven King -- sfking at fdwdc dot com

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Steven King <sfking@fdwdc.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature sensor
Date: Wed, 5 May 2010 08:31:55 -0700	[thread overview]
Message-ID: <201005050831.56526.sfking@fdwdc.com> (raw)
In-Reply-To: <20100504113655.42623e51@hyperion.delvare>

On Tuesday 04 May 2010 2:36:55 Jean Delvare wrote:
> Steven,
>
> On Sat, 3 Apr 2010 09:23:40 +0200, Jean Delvare wrote:
> > On Mon, 15 Mar 2010 13:52:17 +0100, Jean Delvare wrote:
> > > Here's my review. Feel free to pick whatever you like in it and ignore
> > > the rest. Then submit a final version for upstream integration.
> >
> > Any update? Would be great to not lose all the work that both you and
> > me put in this driver so far.
>
> If you do not reply, I will do all the suggested changes myself and
> push the driver upstream.

I'm in the midst of the old '12 hours a day 'til we get this thing off to 
manufacturing' so I havent had time to do more than a cursory look at your 
changes and probably wont for a while longer.  Other than a few minor style 
issues, I didnt see anything I'd take issue with, so if thats what you think is 
the right thing to do, then please do.

-- 
Steven King -- sfking at fdwdc dot com

  reply	other threads:[~2010-05-05 15:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14  4:00 [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature Steven King
2010-03-14  4:00 ` [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Steven King
2010-03-15 12:52 ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature Jean Delvare
2010-03-15 12:52   ` [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Jean Delvare
2010-04-03  7:23   ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature Jean Delvare
2010-04-03  7:23     ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Jean Delvare
2010-05-04  9:36     ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature Jean Delvare
2010-05-04  9:36       ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Jean Delvare
2010-05-05 15:31       ` Steven King [this message]
2010-05-05 15:31         ` Steven King
2010-05-17 12:20         ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature Jean Delvare
2010-05-17 12:20           ` [lm-sensors] [PATCH v2] hwmon: driver for TI tmp102 temperature sensor Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005050831.56526.sfking@fdwdc.com \
    --to=sfking@fdwdc.com \
    --cc=akpm@linux-foundation.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.