From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2] sctp: Fix a race between ICMP protocol unreachable
Date: Thu, 06 May 2010 07:56:52 +0000 [thread overview]
Message-ID: <20100506.005652.123997294.davem@davemloft.net> (raw)
In-Reply-To: <1273088166-18391-1-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 5 May 2010 15:36:06 -0400
> ICMP protocol unreachable handling completely disregarded
> the fact that the user may have locket the socket. It proceeded
> to destroy the association, even though the user may have
> held the lock and had a ref on the association. This resulted
> in the following:
>
> Attempt to release alive inet socket f6afcc00
...
> This was because the sctp_wait_for_connect() would aqcure the socket
> lock and then proceed to release the last reference count on the
> association, thus cause the fully destruction path to finish freeing
> the socket.
>
> The simplest solution is to start a very short timer in case the socket
> is owned by user. When the timer expires, we can do some verification
> and be able to do the release properly.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied and queued up for -stable, thanks Vlad.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2] sctp: Fix a race between ICMP protocol unreachable and connect()
Date: Thu, 06 May 2010 00:56:52 -0700 (PDT) [thread overview]
Message-ID: <20100506.005652.123997294.davem@davemloft.net> (raw)
In-Reply-To: <1273088166-18391-1-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 5 May 2010 15:36:06 -0400
> ICMP protocol unreachable handling completely disregarded
> the fact that the user may have locket the socket. It proceeded
> to destroy the association, even though the user may have
> held the lock and had a ref on the association. This resulted
> in the following:
>
> Attempt to release alive inet socket f6afcc00
...
> This was because the sctp_wait_for_connect() would aqcure the socket
> lock and then proceed to release the last reference count on the
> association, thus cause the fully destruction path to finish freeing
> the socket.
>
> The simplest solution is to start a very short timer in case the socket
> is owned by user. When the timer expires, we can do some verification
> and be able to do the release properly.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied and queued up for -stable, thanks Vlad.
next prev parent reply other threads:[~2010-05-06 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 19:29 [PATCH] sctp: Fix a race between ICMP protocol unreachable and connect() Vlad Yasevich
2010-05-05 19:29 ` Vlad Yasevich
2010-05-05 19:36 ` [PATCH v2] " Vlad Yasevich
2010-05-05 19:36 ` Vlad Yasevich
2010-05-06 7:56 ` David Miller [this message]
2010-05-06 7:56 ` David Miller
2010-05-10 2:56 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable Wei Yongjun
2010-05-10 2:56 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable and connect() Wei Yongjun
2010-05-10 13:59 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable Vlad Yasevich
2010-05-10 13:59 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable and connect() Vlad Yasevich
2010-05-16 7:46 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable David Miller
2010-05-16 7:46 ` [PATCH v2] sctp: Fix a race between ICMP protocol unreachable and connect() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506.005652.123997294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.