From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 04/11] xfs: modify buffer item reference counting V2
Date: Thu, 6 May 2010 17:00:26 -0400 [thread overview]
Message-ID: <20100506210026.GA30264@infradead.org> (raw)
In-Reply-To: <1273110351-2333-5-git-send-email-david@fromorbit.com>
On Thu, May 06, 2010 at 11:45:44AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The buffer log item reference counts used to take reference?? for every
> transaction, similar to the pin counting. This is symmetric (like the
> pin/unpin) with respect to transaction completion, but with dleayed logging
> becomes assymetric as the pinning becomes assymetric w.r.t. transaction
> completion.
>
> To make both cases the same, allow the buffer pinning to take a reference to
> the buffer log item and always drop the reference the transaction has on it
> when being unlocked. This is balanced correctly because the unpin operation
> always drops a reference to the log item. Hence reference counting becomes
> symmetric w.r.t. item pinning as well as w.r.t active transactions and as a
> result the reference counting model remain consistent between normal and
> delayed logging.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good and makes the buffer refconting model a lot more sensible.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-06 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 1:45 [PATCH 0/11] xfs: delayed logging Dave Chinner
2010-05-06 1:45 ` [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions Dave Chinner
2010-05-06 20:41 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 02/11] xfs: Improve scalability of busy extent tracking Dave Chinner
2010-05-06 1:45 ` [PATCH 03/11] xfs: allow log ticket allocation to take allocation flags Dave Chinner
2010-05-06 20:43 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 04/11] xfs: modify buffer item reference counting V2 Dave Chinner
2010-05-06 21:00 ` Christoph Hellwig [this message]
2010-05-06 1:45 ` [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace Dave Chinner
2010-05-06 20:51 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 06/11] xfs: clean up log ticket overrun debug output Dave Chinner
2010-05-06 20:50 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 07/11] xfs: Delayed logging design documentation Dave Chinner
2010-05-06 1:45 ` [PATCH 08/11] xfs: Introduce delayed logging core code Dave Chinner
2010-05-06 1:45 ` [PATCH 09/11] xfs: forced unmounts need to push the CIL Dave Chinner
2010-05-06 1:45 ` [PATCH 10/11] xfs: enable background pushing of " Dave Chinner
2010-05-06 1:45 ` [PATCH 11/11] xfs: Ensure inode allocation buffers are fully replayed Dave Chinner
2010-05-06 13:26 ` [PATCH 0/11] xfs: delayed logging Dave Chinner
2010-05-06 19:12 ` Christoph Hellwig
2010-05-06 23:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506210026.GA30264@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.