From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/11] xfs: delayed logging
Date: Fri, 7 May 2010 09:54:01 +1000 [thread overview]
Message-ID: <20100506235401.GD19579@dastard> (raw)
In-Reply-To: <20100506191218.GA18555@infradead.org>
On Thu, May 06, 2010 at 03:12:18PM -0400, Christoph Hellwig wrote:
> > Secondly, for delayed logging only, matching by transaction
> > structure address triggers the failure because busy extents
> > have a much longer life than the transaction structure. It is clear
> > why the transaction ID matching didn't trip over - it would have
> > triggered a log force in this situation, and hence blocked until
> > the checkpoint that fs_mark-2742 had triggered was complete before
> > redoing the rbtree insert.
>
> True, the busy extents get spliced over to the cil context, so they
> outlive the transaction structure.
>
> > Right now I'm simply going to go back to using the transaction ID
> > for matching transactions, even though the above analysis points out
> > that even that is not as efficient as it could be for delayed
> > logging. That is, we don't even need to force the log or have a
> > synchronous transaction if the extent was first freed in the current
> > checkpoint seqeunce. Doing that, however, requires pinning the
> > checkpoint sequence (i.e. preventing a flush) until the current
> > transaction commits. While that is in the plan for delayed logging,
> > it is future functionality and hence I'm not going to attempt to
> > design and implement it this close to 2.6.35-rc cycle. [*]
>
> Sounds fine to me. I'm not a fan of exporting the tid, but it
> seems like there's no good way around it for now. Please make the
> tid exporting a separate changeset so that it's easily revertable
> once this is sorted out.
Yeah, that's a good idea.
> And documenting all this in comments in the code so that it's archived
> would be very useful!
Will do.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-05-06 23:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 1:45 [PATCH 0/11] xfs: delayed logging Dave Chinner
2010-05-06 1:45 ` [PATCH 01/11] xfs: Don't reuse the same transaciton ID for duplicated transactions Dave Chinner
2010-05-06 20:41 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 02/11] xfs: Improve scalability of busy extent tracking Dave Chinner
2010-05-06 1:45 ` [PATCH 03/11] xfs: allow log ticket allocation to take allocation flags Dave Chinner
2010-05-06 20:43 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 04/11] xfs: modify buffer item reference counting V2 Dave Chinner
2010-05-06 21:00 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 05/11] xfs: Clean up XFS_BLI_* flag namespace Dave Chinner
2010-05-06 20:51 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 06/11] xfs: clean up log ticket overrun debug output Dave Chinner
2010-05-06 20:50 ` Christoph Hellwig
2010-05-06 1:45 ` [PATCH 07/11] xfs: Delayed logging design documentation Dave Chinner
2010-05-06 1:45 ` [PATCH 08/11] xfs: Introduce delayed logging core code Dave Chinner
2010-05-06 1:45 ` [PATCH 09/11] xfs: forced unmounts need to push the CIL Dave Chinner
2010-05-06 1:45 ` [PATCH 10/11] xfs: enable background pushing of " Dave Chinner
2010-05-06 1:45 ` [PATCH 11/11] xfs: Ensure inode allocation buffers are fully replayed Dave Chinner
2010-05-06 13:26 ` [PATCH 0/11] xfs: delayed logging Dave Chinner
2010-05-06 19:12 ` Christoph Hellwig
2010-05-06 23:54 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506235401.GD19579@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.