All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][BUGFIX for .33 and .34] hda - fix DG45ID SPDIF output
@ 2010-05-07  0:47 Wu Fengguang
  2010-05-07  8:35 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Wu Fengguang @ 2010-05-07  0:47 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: alsa-user@lists.sourceforge.net, alsa-devel@alsa-project.org,
	Alexey Fisher, stable, David Härdeman

This reverts part of commit 52dc438606d1e, in order to fix a regression:
broken SPDIF output on Intel DG45FC motherboard (IDT 92HD73E1X5 codec).

	--- DG45FC-IDT-codec-2.6.32  (SPDIF OK)
	+++ DG45FC-IDT-codec-2.6.33  (SPDIF broken)

	 Node 0x22 [Pin Complex] wcaps 0x400301: Stereo Digital
	   Pincap 0x00000010: OUT
	-  Pin Default 0x40f000f0: [N/A] Other at Ext N/A
	-    Conn = Unknown, Color = Unknown
	-    DefAssociation = 0xf, Sequence = 0x0
	-  Pin-ctls: 0x00:
	+  Pin Default 0x014510a0: [Jack] SPDIF Out at Ext Rear
	+    Conn = Optical, Color = Black
	+    DefAssociation = 0xa, Sequence = 0x0
	+  Pin-ctls: 0x40: OUT
	   Connection: 3
	      0x25* 0x20 0x21
	 Node 0x23 [Pin Complex] wcaps 0x400301: Stereo Digital
	   Pincap 0x00000010: OUT
	-  Pin Default 0x01451140: [Jack] SPDIF Out at Ext Rear
	+  Pin Default 0x074510b0: [Jack] SPDIF Out at Ext Rear Panel
	     Conn = Optical, Color = Black
	-    DefAssociation = 0x4, Sequence = 0x0
	-    Misc = NO_PRESENCE
	-  Pin-ctls: 0x40: OUT
	+    DefAssociation = 0xb, Sequence = 0x0
	+  Pin-ctls: 0x00:
	   Connection: 3
	      0x26* 0x20 0x21

CC: <stable@kernel.org>
CC: Alexey Fisher <bug-track@fisher-privat.net>
Tested-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 sound/pci/hda/patch_sigmatel.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- sound-2.6.orig/sound/pci/hda/patch_sigmatel.c	2010-05-06 18:10:30.000000000 +0800
+++ sound-2.6/sound/pci/hda/patch_sigmatel.c	2010-05-06 19:34:48.000000000 +0800
@@ -1544,11 +1544,9 @@ static unsigned int alienware_m17x_pin_c
 	0x904601b0,
 };
 
-static unsigned int intel_dg45id_pin_configs[14] = {
+static unsigned int intel_dg45id_pin_configs[13] = {
 	0x02214230, 0x02A19240, 0x01013214, 0x01014210,
-	0x01A19250, 0x01011212, 0x01016211, 0x40f000f0,
-	0x40f000f0, 0x40f000f0, 0x40f000f0, 0x014510A0,
-	0x074510B0, 0x40f000f0
+	0x01A19250, 0x01011212, 0x01016211
 };
 
 static unsigned int *stac92hd73xx_brd_tbl[STAC_92HD73XX_MODELS] = {
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][BUGFIX for .33 and .34] hda - fix DG45ID SPDIF output
  2010-05-07  0:47 [PATCH][BUGFIX for .33 and .34] hda - fix DG45ID SPDIF output Wu Fengguang
@ 2010-05-07  8:35 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-05-07  8:35 UTC (permalink / raw)
  To: Wu Fengguang
  Cc: alsa-user@lists.sourceforge.net, alsa-devel@alsa-project.org,
	Alexey Fisher, stable, David Härdeman

At Fri, 7 May 2010 08:47:54 +0800,
Wu Fengguang wrote:
> 
> This reverts part of commit 52dc438606d1e, in order to fix a regression:
> broken SPDIF output on Intel DG45FC motherboard (IDT 92HD73E1X5 codec).
> 
> 	--- DG45FC-IDT-codec-2.6.32  (SPDIF OK)
> 	+++ DG45FC-IDT-codec-2.6.33  (SPDIF broken)
> 
> 	 Node 0x22 [Pin Complex] wcaps 0x400301: Stereo Digital
> 	   Pincap 0x00000010: OUT
> 	-  Pin Default 0x40f000f0: [N/A] Other at Ext N/A
> 	-    Conn = Unknown, Color = Unknown
> 	-    DefAssociation = 0xf, Sequence = 0x0
> 	-  Pin-ctls: 0x00:
> 	+  Pin Default 0x014510a0: [Jack] SPDIF Out at Ext Rear
> 	+    Conn = Optical, Color = Black
> 	+    DefAssociation = 0xa, Sequence = 0x0
> 	+  Pin-ctls: 0x40: OUT
> 	   Connection: 3
> 	      0x25* 0x20 0x21
> 	 Node 0x23 [Pin Complex] wcaps 0x400301: Stereo Digital
> 	   Pincap 0x00000010: OUT
> 	-  Pin Default 0x01451140: [Jack] SPDIF Out at Ext Rear
> 	+  Pin Default 0x074510b0: [Jack] SPDIF Out at Ext Rear Panel
> 	     Conn = Optical, Color = Black
> 	-    DefAssociation = 0x4, Sequence = 0x0
> 	-    Misc = NO_PRESENCE
> 	-  Pin-ctls: 0x40: OUT
> 	+    DefAssociation = 0xb, Sequence = 0x0
> 	+  Pin-ctls: 0x00:
> 	   Connection: 3
> 	      0x26* 0x20 0x21
> 
> CC: <stable@kernel.org>
> CC: Alexey Fisher <bug-track@fisher-privat.net>
> Tested-by: David Härdeman <david@hardeman.nu>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

Applied now.  Thanks!


Takashi

> ---
>  sound/pci/hda/patch_sigmatel.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- sound-2.6.orig/sound/pci/hda/patch_sigmatel.c	2010-05-06 18:10:30.000000000 +0800
> +++ sound-2.6/sound/pci/hda/patch_sigmatel.c	2010-05-06 19:34:48.000000000 +0800
> @@ -1544,11 +1544,9 @@ static unsigned int alienware_m17x_pin_c
>  	0x904601b0,
>  };
>  
> -static unsigned int intel_dg45id_pin_configs[14] = {
> +static unsigned int intel_dg45id_pin_configs[13] = {
>  	0x02214230, 0x02A19240, 0x01013214, 0x01014210,
> -	0x01A19250, 0x01011212, 0x01016211, 0x40f000f0,
> -	0x40f000f0, 0x40f000f0, 0x40f000f0, 0x014510A0,
> -	0x074510B0, 0x40f000f0
> +	0x01A19250, 0x01011212, 0x01016211
>  };
>  
>  static unsigned int *stac92hd73xx_brd_tbl[STAC_92HD73XX_MODELS] = {
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-07  8:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-07  0:47 [PATCH][BUGFIX for .33 and .34] hda - fix DG45ID SPDIF output Wu Fengguang
2010-05-07  8:35 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.