* [patch] ceph: cleanup: remove unused assignement
@ 2010-05-07 8:27 Dan Carpenter
2010-05-07 21:42 ` Sage Weil
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-07 8:27 UTC (permalink / raw)
To: Sage Weil; +Cc: Yehuda Sadeh, ceph-devel
We don't ever use "dirty" so we can remove it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index 0c16818..a8db1a6 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1711,10 +1711,9 @@ out_unlocked:
static int caps_are_flushed(struct inode *inode, unsigned tid)
{
struct ceph_inode_info *ci = ceph_inode(inode);
- int dirty, i, ret = 1;
+ int i, ret = 1;
spin_lock(&inode->i_lock);
- dirty = __ceph_caps_dirty(ci);
for (i = 0; i < CEPH_CAP_BITS; i++)
if ((ci->i_flushing_caps & (1 << i)) &&
ci->i_cap_flush_tid[i] <= tid) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ceph: cleanup: remove unused assignement
2010-05-07 8:27 [patch] ceph: cleanup: remove unused assignement Dan Carpenter
@ 2010-05-07 21:42 ` Sage Weil
0 siblings, 0 replies; 2+ messages in thread
From: Sage Weil @ 2010-05-07 21:42 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Yehuda Sadeh, ceph-devel
On Fri, 7 May 2010, Dan Carpenter wrote:
> We don't ever use "dirty" so we can remove it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
> index 0c16818..a8db1a6 100644
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -1711,10 +1711,9 @@ out_unlocked:
> static int caps_are_flushed(struct inode *inode, unsigned tid)
> {
> struct ceph_inode_info *ci = ceph_inode(inode);
> - int dirty, i, ret = 1;
> + int i, ret = 1;
>
> spin_lock(&inode->i_lock);
> - dirty = __ceph_caps_dirty(ci);
> for (i = 0; i < CEPH_CAP_BITS; i++)
> if ((ci->i_flushing_caps & (1 << i)) &&
> ci->i_cap_flush_tid[i] <= tid) {
Queued up for the 2.6.35 window.
Thanks!
sage
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-07 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-07 8:27 [patch] ceph: cleanup: remove unused assignement Dan Carpenter
2010-05-07 21:42 ` Sage Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.