All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	Chuck Ebbert <cebbert@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	kernel-janitors@vger.kernel.org
Subject: [patch] bio-integrity: use hardware sectors instead of block layer sectors
Date: Fri, 7 May 2010 10:29:28 +0200	[thread overview]
Message-ID: <20100507082928.GT27064@bicker> (raw)

Smatch tagged this code as suspicious because we never use the
"nr_sectors" variable.  Looking at the code, I think we did intend to
use "nr_sectors" instead of "sectors" when we call
bio_integrity_mark_tail().

The difference between "sectors" and "nr_sectors" is that "sectors" is in
terms of 512 byte sectors and "nr_sectors" is in terms of hardware 
sectors.  They are only different for 4k sector devices.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I'm only guessing as to the intent and I can't test this myself.  Please
handle with care.

diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
index 612a5c3..ce65453 100644
--- a/fs/bio-integrity.c
+++ b/fs/bio-integrity.c
@@ -676,7 +676,7 @@ void bio_integrity_trim(struct bio *bio, unsigned int offset,
 	nr_sectors = bio_integrity_hw_sectors(bi, sectors);
 	bip->bip_sector = bip->bip_sector + offset;
 	bio_integrity_mark_head(bip, offset * bi->tuple_size);
-	bio_integrity_mark_tail(bip, sectors * bi->tuple_size);
+	bio_integrity_mark_tail(bip, nr_sectors * bi->tuple_size);
 }
 EXPORT_SYMBOL(bio_integrity_trim);
 

             reply	other threads:[~2010-05-07  8:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07  8:29 Dan Carpenter [this message]
2010-05-07  9:32 ` [patch] bio-integrity: use hardware sectors instead of block layer sectors Jamie Lokier
2010-05-07  9:54 ` [patch v2] bio-integrity: use hardware sectors instead of block Dan Carpenter
2010-05-07  9:54   ` [patch v2] bio-integrity: use hardware sectors instead of block layer sectors Dan Carpenter
2010-05-17 19:06   ` Martin K. Petersen
2010-05-17 19:06     ` Martin K. Petersen
2011-04-05 20:35     ` [patch v2] bio-integrity: use hardware sectors instead of block Jonathan Nieder
2011-04-05 20:35       ` [patch v2] bio-integrity: use hardware sectors instead of block layer sectors Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100507082928.GT27064@bicker \
    --to=error27@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.