From: Jamie Lokier <jamie@shareable.org>
To: Dan Carpenter <error27@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <jens.axboe@oracle.com>,
Chuck Ebbert <cebbert@redhat.com>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] bio-integrity: use hardware sectors instead of block layer sectors
Date: Fri, 7 May 2010 10:32:52 +0100 [thread overview]
Message-ID: <20100507093252.GC19699@shareable.org> (raw)
In-Reply-To: <20100507082928.GT27064@bicker>
Dan Carpenter wrote:
> Smatch tagged this code as suspicious because we never use the
> "nr_sectors" variable. Looking at the code, I think we did intend to
> use "nr_sectors" instead of "sectors" when we call
> bio_integrity_mark_tail().
>
> The difference between "sectors" and "nr_sectors" is that "sectors" is in
> terms of 512 byte sectors and "nr_sectors" is in terms of hardware
> sectors. They are only different for 4k sector devices.
That code is so asking for the variable to be called "hw_sectors".
-- Jamie
next prev parent reply other threads:[~2010-05-07 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 8:29 [patch] bio-integrity: use hardware sectors instead of block layer sectors Dan Carpenter
2010-05-07 9:32 ` Jamie Lokier [this message]
2010-05-07 9:54 ` [patch v2] bio-integrity: use hardware sectors instead of block Dan Carpenter
2010-05-07 9:54 ` [patch v2] bio-integrity: use hardware sectors instead of block layer sectors Dan Carpenter
2010-05-17 19:06 ` Martin K. Petersen
2010-05-17 19:06 ` Martin K. Petersen
2011-04-05 20:35 ` [patch v2] bio-integrity: use hardware sectors instead of block Jonathan Nieder
2011-04-05 20:35 ` [patch v2] bio-integrity: use hardware sectors instead of block layer sectors Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507093252.GC19699@shareable.org \
--to=jamie@shareable.org \
--cc=cebbert@redhat.com \
--cc=error27@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.