Re: [PATCH v2] libsocketcan: new recipe

[Stefan Schmidt <stefan@datenfreihafen.org>]

Hello.

I was going to apply them, but I found some stuff I would like to get sorted out
first. See below.

On Sat, 2010-05-01 at 16:22, Vitus Jensen wrote:
> Builds pengutronix' libsocketcan (using the new netlink interface to access
> CAN drivers)
> 
> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
> --- /dev/null
> +++ b/recipes/socketcan/libsocketcan_0.0.7.bb
> @@ -0,0 +1,17 @@
> +DESCRIPTION = "control basic functions in socketcan from userspace"

Nitpick. Staring with a upper letter would be nice.

> +AUTHOR = "Luotao Fu"
> +HOMEPAGE = "http://www.pengutronix.de"
> +SECTION = "libs/network"
> +PRIORITY = "optional"
> +LICENSE = "LGPL"
> +
> +TAG = "v${PV}"
> +PR = "r0"
> +
> +SRC_URI = "git://git.pengutronix.de/git/tools/libsocketcan.git;protocol=git;tag=${TAG} \

Does Pengutronix not have release tarballs for this? In a recipe without _git.bb
postfix I did not expect to find git SRC_URIs.

> +	file://0001-remove-headers-supplied-by-linux-libc-headers.patch;patch=1 \
> +	"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig

regards
Stefan Schmidt