Re: [PATCH v2] canutils: new recipe

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07-05-10 12:18, Stefan Schmidt wrote:
> Hello.
> 
> On Sat, 2010-05-01 at 16:22, Vitus Jensen wrote:
>> Adds canutils (PTX flavour) 4.0.4 as alternative to socketcan-utils-test.
>> canutils RCONFLICTS with socketcan-utils-test because of identical
>> file names.
>>
>> Signed-off-by: Vitus Jensen <vjensen@gmx.de>
>> ---
>>  recipes/socketcan/canutils_4.0.4.bb           |   19 +++++++++++++++++++
>>  recipes/socketcan/socketcan-utils-test_svn.bb |    1 +
>>  2 files changed, 20 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/socketcan/canutils_4.0.4.bb
>>
>> diff --git a/recipes/socketcan/canutils_4.0.4.bb b/recipes/socketcan/canutils_4.0.4.bb
>> new file mode 100644
>> index 0000000..e769c46
>> --- /dev/null
>> +++ b/recipes/socketcan/canutils_4.0.4.bb
>> @@ -0,0 +1,19 @@
>> +DESCRIPTION = "canutils (PTX flavour)"
>> +AUTHOR = "Luotao Fu"
>> +HOMEPAGE = "http://www.pengutronix.de"
>> +SECTION = "console/network"
>> +PRIORITY = "optional"
>> +LICENSE = "LGPL"
>> +DEPENDS = "libsocketcan"
>> +RDEPENDS = "libsocketcan"
> 
> Why do you need this RDEPENDS on the lib when it is already in DEPENDS?

The better question is "Why doesn't OE shlib code pickup that
dependency?" :)

Regardless of that, RDEPENDS = "foo" is bad, RDEPENDS_${PN} = "foo" is
better. Chris created the recipe sanity stuff to check for these kinds
of things.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFL4/Y2MkyGM64RGpERApiGAKCHkZaERI3RjRMFni0srqrz1bK1zACgh4Oc
txgZHww4OIZWD+cvr+GWb5w=
=eDEU
-----END PGP SIGNATURE-----