All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Dajun Chen <Dajun.Chen@diasemi.com>
Cc: linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>,
	sameo@linux.intel.com, lm-sensors@lm-sensors.org,
	rpurdie@rpsys.net, lrg@slimlogic.co.uk,
	dmitry.torokhov@gmail.com
Subject: Re: [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC
Date: Fri, 07 May 2010 16:18:58 +0000	[thread overview]
Message-ID: <20100507161858.GB20909@kroah.com> (raw)
In-Reply-To: <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com>

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

Oh, also please run your code through the scripts/checkpatch.pl script.
It found:
	total: 4635 errors, 1558 warnings, 24394 lines checked
with this patch.

If you don't want to do the work to fix this up, please let me know and
I'll be glad to move these drivers into the staging tree, where they can
live until stuff like this is cleaned up.

thanks,

greg k-h

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: David Dajun Chen <Dajun.Chen@diasemi.com>
Cc: linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>,
	sameo@linux.intel.com, lm-sensors@lm-sensors.org,
	rpurdie@rpsys.net, lrg@slimlogic.co.uk,
	dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Device driver for DA9052 PMIC IC
Date: Fri, 7 May 2010 09:18:58 -0700	[thread overview]
Message-ID: <20100507161858.GB20909@kroah.com> (raw)
In-Reply-To: <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com>

On Fri, May 07, 2010 at 12:43:27PM +0100, David Dajun Chen wrote:
> Dear all,
> 
> It is device driver for DA9052 Power Management IC from Dialog Semiconductor.

Oh, also please run your code through the scripts/checkpatch.pl script.
It found:
	total: 4635 errors, 1558 warnings, 24394 lines checked
with this patch.

If you don't want to do the work to fix this up, please let me know and
I'll be glad to move these drivers into the staging tree, where they can
live until stuff like this is cleaned up.

thanks,

greg k-h

  parent reply	other threads:[~2010-05-07 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3495EC08FA53E94AAA00CC4743D5BA7E010C1E94@pandora.diasemi.com>
2010-05-07 16:13 ` [lm-sensors] [PATCH] Device driver for DA9052 PMIC IC Greg KH
2010-05-07 16:13   ` Greg KH
2010-05-07 16:18 ` Greg KH [this message]
2010-05-07 16:18   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100507161858.GB20909@kroah.com \
    --to=greg@kroah.com \
    --cc=Dajun.Chen@diasemi.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=rpurdie@rpsys.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.