All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 15906] performance regression in "umount" of filesystems using barriers
Date: Sat, 8 May 2010 14:30:32 GMT	[thread overview]
Message-ID: <201005081430.o48EUWDw021756@demeter.kernel.org> (raw)
In-Reply-To: <bug-15906-13602@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=15906


Thierry Vignaud <thierry.vignaud@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thierry.vignaud@gmail.com




--- Comment #20 from Dmitry Monakhov <dmonakhov@openvz.org>  2010-05-07 09:45:32 ---
I can confirm that Jens's fix the original regression for me,
so IMHO first part well done.

About second one.
(In reply to comment #13)
> A delalloc option. In fact dirty inode is still dirty even after first
> call of writeback_single_inode which is called from __sync_filesystem(0)
> due to delalloc allocation happen during inode write. So it takes second
> __sync_filesystem call to clear dirty flags. Currently i'm working on that
> issue. I hope i'll post a solution today.

Proposed patch was posted may be found here: 
http://marc.info/?l=linux-fsdevel&m=127322500915287&w=2

--- Comment #21 from Dmitry Monakhov <dmonakhov@openvz.org>  2010-05-07 10:49:00 ---
#########################################
# Testcase
#Prep stage
for ((i=0;i<1000;i++)) ;do echo test > /tmp/FILES/file-$i ;done
tar cf /tmp/files.tar /tmp/FILES
#Actual measurements  
FSTYPE=ext4
OPT='-obarrier=1'
mkfs.$FSTYPE /dev/sdb1 
mount /dev/sdb1 /mnt  $OPT
time tar xf /tmp/files.tar  -C /mnt/
time umount /mnt
#########################################

w/o update dflags patch
real    0m0.142s
user    0m0.005s
sys     0m0.093s

real    0m8.506s
user    0m0.000s
sys     0m0.016s

with update dflags patch
real    0m0.105s
user    0m0.006s
sys     0m0.086s

real    0m0.148s
user    0m0.002s
sys     0m0.007s

Seems where are no visible diffidence for btrfs and xfs.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

  parent reply	other threads:[~2010-05-08 14:30 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 20:36 [Bug 15906] New: serious performance regression in "umount" on ext4 over LVM bugzilla-daemon
2010-05-04 20:37 ` [Bug 15906] " bugzilla-daemon
2010-05-04 20:41 ` bugzilla-daemon
2010-05-04 20:52 ` bugzilla-daemon
2010-05-04 21:05 ` bugzilla-daemon
2010-05-04 21:11 ` bugzilla-daemon
2010-05-04 21:12 ` bugzilla-daemon
2010-05-04 21:34 ` bugzilla-daemon
2010-05-04 21:48 ` bugzilla-daemon
2010-05-05  0:28 ` bugzilla-daemon
2010-05-05  3:18 ` bugzilla-daemon
2010-05-05  4:00 ` bugzilla-daemon
2010-05-05  4:46 ` bugzilla-daemon
2010-05-05  7:28 ` bugzilla-daemon
2010-05-05  8:27   ` Dmitry Monakhov
2010-05-05  8:40     ` Jens Axboe
2010-05-05  9:06       ` Dmitry Monakhov
2010-05-05  7:30 ` bugzilla-daemon
2010-05-05 19:44 ` bugzilla-daemon
2010-05-05 20:34 ` [Bug 15906] performance regression in "umount" of filesystems using barriers bugzilla-daemon
2010-05-05 21:36   ` Greg Freemyer
2010-05-05 20:34 ` bugzilla-daemon
2010-05-05 21:36 ` bugzilla-daemon
2010-05-05 21:55   ` Greg Freemyer
2010-05-06  3:49 ` bugzilla-daemon
2010-05-06  7:09 ` bugzilla-daemon
2010-05-06  7:10 ` bugzilla-daemon
2010-05-07  9:47 ` bugzilla-daemon
2010-05-08 14:30 ` bugzilla-daemon [this message]
2010-05-17  3:28 ` bugzilla-daemon
2010-05-17  3:44 ` bugzilla-daemon
2010-05-17 10:52 ` bugzilla-daemon
2010-05-19 18:57 ` bugzilla-daemon
2010-05-19 19:12 ` bugzilla-daemon
2010-05-21  1:05 ` bugzilla-daemon
2010-05-21  2:07 ` bugzilla-daemon
2010-05-21  6:08 ` bugzilla-daemon
2010-05-22  4:38 ` bugzilla-daemon
2010-05-26 16:44 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005081430.o48EUWDw021756@demeter.kernel.org \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.