Re: [PATCHv2] Support for booting from virtio disks

[Gleb Natapov <gleb@redhat.com>]

On Mon, May 10, 2010 at 09:25:20AM +0100, Stefan Hajnoczi wrote:
> > diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> > new file mode 100644
> > index 0000000..a41c336
> > --- /dev/null
> > +++ b/src/virtio-blk.c
> > @@ -0,0 +1,155 @@
> > +// Virtio blovl boot support.
> 
> Just noticed the "blovl" typo.
> 
> > +        char *desc = malloc_tmphigh(MAXDESCSIZE);
> > +        struct virtiodrive_s *vdrive_g = malloc_fseg(sizeof(*vdrive_g));
> > +        struct vring_virtqueue *vq = malloc_low(sizeof(*vq));
> > +        if (!vdrive_g || !desc || !vq) {
> > +            warn_noalloc();
> > +            return;
> > +        }
> 
> This error return can still leak.
> 
Oh Gosh, programming is hard. Why don't we write bios in python?

--
			Gleb.