From: Christoph Egger <Christoph.Egger@amd.com>
To: qemu-devel@nongnu.org
Cc: 乔崇 <qiaochong@loongson.cn>, "Joerg Roedel" <joro@8bytes.org>,
"Elek Roland" <elek.roland@gmail.com>,
"Alexander Graf" <agraf@suse.de>,
"Sebastian Herbszt" <herbszt@gmx.de>
Subject: Re: [Qemu-devel] AHCI support integration
Date: Mon, 10 May 2010 10:10:58 +0200 [thread overview]
Message-ID: <201005101011.00620.Christoph.Egger@amd.com> (raw)
In-Reply-To: <1945C1D2D39F43239CFD537CA66DA5F8@FSCPC>
On Sunday 09 May 2010 18:01:50 Sebastian Herbszt wrote:
> The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt
> (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA
> specification. The code in hw/ide/* on the other hand is split (or could be
> split) into smaller parts like port based and bus master access, IDE and
> ATA core.
> I think it might be reasonable to split ahci.c into ICH6, AHCI and SATA
> parts and strip the limited ATA support and reuse it from the ide core.
> This would give us something like the following:
>
> hw/ide/piix.c (PIIX3 and PIIX4)
> hw/ide/pci.c and core.c (IDE, BM)
> hw/ata-core.c (ATA)
> hw/sata/ich6.c (ICH6)
> hw/sata-core.c (SATA)
> hw/ahci-core.c (AHCI)
>
> Should this be a goal or am i over-engineering here?
I think this will result in code much easier to read and to
maintain. You can even split out FIS code
into a seperate file since not every SATA controller is
an AHCI controller.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2010-05-10 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 16:01 [Qemu-devel] AHCI support integration Sebastian Herbszt
2010-05-09 19:11 ` [Qemu-devel] " Alexander Graf
2010-05-10 6:55 ` Tejun Heo
2010-05-10 8:12 ` Christoph Egger
2010-05-10 9:45 ` Joerg Roedel
2010-05-10 8:10 ` Christoph Egger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005101011.00620.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=agraf@suse.de \
--cc=elek.roland@gmail.com \
--cc=herbszt@gmx.de \
--cc=joro@8bytes.org \
--cc=qemu-devel@nongnu.org \
--cc=qiaochong@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.