From: Robert Richter <robert.richter@amd.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "mingo@elte.hu" <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Lin Ming <ming.m.lin@intel.com>
Subject: Re: [patch 1/4] x86,perf: P4 PMU -- configurate predefined events
Date: Mon, 10 May 2010 14:43:53 +0200 [thread overview]
Message-ID: <20100510124353.GG6450@erda.amd.com> (raw)
In-Reply-To: <20100508112716.741423821@openvz.org>
On 08.05.10 07:25:51, Cyrill Gorcunov wrote:
> If an event is not RAW we should exit p4_hw_config
> early but call x86_setup_perfctr as well.
>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Lin Ming <ming.m.lin@intel.com>
> CC: Robert Richter <robert.richter@amd.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
>
> Robert, if only I'm not missing something this is
> a side effect of commit 9d0fcba67e47ff398a6fa86476d4884d472dc98a,
> wonders why don't we hit it earlier. Am I wrong?
Yes, that's true, the function had have two exit points. Thanks for
the fix.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2010-05-10 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 11:25 [patch 0/4] perf,p4 series for -tip Cyrill Gorcunov
2010-05-08 11:25 ` [patch 1/4] x86,perf: P4 PMU -- configurate predefined events Cyrill Gorcunov
2010-05-08 11:33 ` Cyrill Gorcunov
2010-05-10 12:43 ` Robert Richter [this message]
2010-05-08 11:25 ` [patch 2/4] x86,perf: P4 PMU -- protect sensible procedures from preemption Cyrill Gorcunov
2010-05-08 16:09 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
2010-05-08 11:25 ` [patch 3/4] x86,perf: P4 PMU -- Get rid of redundant check for array index Cyrill Gorcunov
2010-05-08 16:10 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
2010-05-08 11:25 ` [patch 4/4] x86,perf: P4 PMU -- check for proper event index in RAW events Cyrill Gorcunov
2010-05-08 16:10 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510124353.GG6450@erda.amd.com \
--to=robert.richter@amd.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.