All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 10/11] __setup_vector_irq: handle NULL chip_data
Date: Mon, 10 May 2010 11:35:13 -0400	[thread overview]
Message-ID: <20100510153513.GJ29517@phenom.dumpdata.com> (raw)
In-Reply-To: <1273501247-27267-11-git-send-email-stefano.stabellini@eu.citrix.com>

On Mon, May 10, 2010 at 03:20:46PM +0100, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  arch/x86/kernel/apic/io_apic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 96f6bba..976646f 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1287,6 +1287,8 @@ void __setup_vector_irq(int cpu)
>  	/* Mark the inuse vectors */
>  	for_each_irq_desc(irq, desc) {
>  		cfg = desc->chip_data;
> +		if (!cfg)
> +			continue;
>  		if (!cpumask_test_cpu(cpu, cfg->domain))
>  			continue;
>  		vector = cfg->vector;

Most curious. This looks be fixed upstream:

http://lkml.org/lkml/2010/4/30/458

Do you know why the chip_data isn't set?

  reply	other threads:[~2010-05-10 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 14:20 [PATCH 10/11] __setup_vector_irq: handle NULL chip_data Stefano Stabellini
2010-05-10 15:35 ` Konrad Rzeszutek Wilk [this message]
2010-05-11 11:20   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100510153513.GJ29517@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.