From: Dan Carpenter <error27@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [patch 2/9] ath9k: range checking issues in htc_hst.c
Date: Tue, 11 May 2010 11:29:38 +0200 [thread overview]
Message-ID: <20100511092938.GY27064@bicker> (raw)
In-Reply-To: <19432.61450.971181.675920@gargle.gargle.HOWL>
On Tue, May 11, 2010 at 11:20:02AM +0530, Sujith.Manoharan at atheros.com wrote:
> Dan Carpenter wrote:
> > The original code had ENDPOINT_MAX and HST_ENDPOINT_MAX switched.
> >
> > Also the first loop was off by one, it started past the end of the array
> > and went down to 1 instead of going down to 0. The test at the end of
> > the loop to see if we exited via a break wasn't right because
> > "tmp_endpoint" is always non-null here.
>
> This is a very good catch and fixes a stack corruption issue.
> Do you mind if I work upon this patch and send out an updated fix ?
>
> Sujith
Sorry, I meant to do that yesterday but I was out of it. Yes. Please
send the updated fix.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Sujith.Manoharan@atheros.com
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
Ming Lei <tom.leiming@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Subject: Re: [patch 2/9] ath9k: range checking issues in htc_hst.c
Date: Tue, 11 May 2010 11:29:38 +0200 [thread overview]
Message-ID: <20100511092938.GY27064@bicker> (raw)
In-Reply-To: <19432.61450.971181.675920@gargle.gargle.HOWL>
On Tue, May 11, 2010 at 11:20:02AM +0530, Sujith.Manoharan@atheros.com wrote:
> Dan Carpenter wrote:
> > The original code had ENDPOINT_MAX and HST_ENDPOINT_MAX switched.
> >
> > Also the first loop was off by one, it started past the end of the array
> > and went down to 1 instead of going down to 0. The test at the end of
> > the loop to see if we exited via a break wasn't right because
> > "tmp_endpoint" is always non-null here.
>
> This is a very good catch and fixes a stack corruption issue.
> Do you mind if I work upon this patch and send out an updated fix ?
>
> Sujith
Sorry, I meant to do that yesterday but I was out of it. Yes. Please
send the updated fix.
regards,
dan carpenter
next prev parent reply other threads:[~2010-05-11 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 16:22 [ath9k-devel] [patch 2/9] ath9k: range checking issues in htc_hst.c Dan Carpenter
2010-05-08 16:22 ` Dan Carpenter
2010-05-10 4:37 ` [ath9k-devel] " Sujith
2010-05-10 4:37 ` Sujith
2010-05-10 10:23 ` [ath9k-devel] " Dan Carpenter
2010-05-10 10:23 ` Dan Carpenter
2010-05-10 10:50 ` [ath9k-devel] " Sujith
2010-05-10 10:50 ` Sujith
2010-05-10 12:17 ` [ath9k-devel] " Pavel Roskin
2010-05-10 12:17 ` Pavel Roskin
2010-05-11 5:50 ` Sujith.Manoharan at atheros.com
2010-05-11 5:50 ` Sujith.Manoharan
2010-05-11 9:29 ` Dan Carpenter [this message]
2010-05-11 9:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511092938.GY27064@bicker \
--to=error27@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.