From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, gpxe-devel@etherboot.org,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.
Date: Tue, 11 May 2010 13:58:57 -0400 [thread overview]
Message-ID: <201005111358.58413.konrad@darnok.org> (raw)
In-Reply-To: <20100421142634.ea5ca8a5.akpm@linux-foundation.org>
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
> > Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
>
> This should have Peter's Signed-off-by:, please.
>
Done.
> > ...
> >
> > +#ifdef CONFIG_ACPI
> > +static int __init acpi_find_ibft(struct acpi_table_header *header)
> > +{
> > + ibft_addr = (struct acpi_table_ibft *)header;
>
> container_of() would be better here. And maybe elsewhere, too.
Actually there is no need for that. We are just casting it, not getting any
internal member.
next prev parent reply other threads:[~2010-05-11 18:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 14:21 [PATCH] Update iBFT to 1.03 Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec Konrad Rzeszutek Wilk
2010-04-21 21:26 ` Andrew Morton
2010-05-11 17:58 ` Konrad Rzeszutek Wilk [this message]
2010-05-12 5:26 ` Len Brown
2010-05-12 13:58 ` [LKML] " Konrad Rzeszutek Wilk
2010-05-12 14:09 ` Peter Jones
2010-05-12 14:12 ` [PATCH] Use IBFT_SIGN instead of open-coding the search string Peter Jones
2010-05-12 14:25 ` Peter Jones
2010-05-12 14:35 ` [PATCH] ibft: " Konrad Rzeszutek Wilk
2010-05-12 19:33 ` Andrew Morton
2010-05-12 23:53 ` H. Peter Anvin
2010-05-27 17:59 ` Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 2/2] ibft: For UEFI machines actually do scan ACPI for iBFT Konrad Rzeszutek Wilk
2010-04-21 21:29 ` Andrew Morton
2010-04-21 21:37 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005111358.58413.konrad@darnok.org \
--to=konrad@darnok.org \
--cc=akpm@linux-foundation.org \
--cc=gpxe-devel@etherboot.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.