All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
	linux-kernel@vger.kernel.org, gpxe-devel@etherboot.org,
	Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH 2/2] ibft: For UEFI machines actually do scan ACPI for iBFT.
Date: Wed, 21 Apr 2010 16:37:59 -0500	[thread overview]
Message-ID: <4BCF7037.9070301@cs.wisc.edu> (raw)
In-Reply-To: <20100421142928.9699de85.akpm@linux-foundation.org>

On 04/21/2010 04:29 PM, Andrew Morton wrote:
> On Fri,  9 Apr 2010 14:21:28 +0000
> Konrad Rzeszutek Wilk<konrad@kernel.org>  wrote:
>
>> For machines with IBFT 1.03 do scan the ACPI table for 'iBFT'
>> or for 'IBFT'. If the machine is in UEFI mode, only do the ACPI
>> table scan. For all other machines (pre IBFT 1.03) do
>> a memory scan if not found in the ACPI tables.
>>
>> Author: Konrad Rzeszutek Wilk<konrad@kernel.org>
>
> The Author: line is unneeded and inappropriate here.  That's what the
> From: line does.
>
>> Acked-by: Peter Jones<pjones@redhat.com>
>> Tested-by: Mike Christie<michaelc@cs.wisc.edu>
>> Signed-off-by: Konrad Rzeszutek Wilk<konrad@kernel.org>
>
> Your covering email indicates that Mike and Peter wrote the patches,
> but neither of the patches have their signoffs.  Can we please sort all
> this out?
>

I did a small fix to 
ibft-update-ibft-handling-for-v103-of-the-spec.patch to get it to 
compile. It looks like that patch has a "Reviewed-by: Mike Christie 
<michaelc@cs.wisc.edu>". Feel free to change that to a Signed-off-by: 
Mike Christie <michaelc@cs.wisc.edu> if needed.

I did not do any changes to 
ibft-for-uefi-machines-actually-do-scan-acpi-for-ibft.patch.

I tested both patches.

      reply	other threads:[~2010-04-21 21:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 14:21 [PATCH] Update iBFT to 1.03 Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec Konrad Rzeszutek Wilk
2010-04-21 21:26   ` Andrew Morton
2010-05-11 17:58     ` Konrad Rzeszutek Wilk
2010-05-12  5:26   ` Len Brown
2010-05-12 13:58     ` [LKML] " Konrad Rzeszutek Wilk
2010-05-12 14:09     ` Peter Jones
2010-05-12 14:12       ` [PATCH] Use IBFT_SIGN instead of open-coding the search string Peter Jones
2010-05-12 14:25       ` Peter Jones
2010-05-12 14:35         ` [PATCH] ibft: " Konrad Rzeszutek Wilk
2010-05-12 19:33           ` Andrew Morton
2010-05-12 23:53             ` H. Peter Anvin
2010-05-27 17:59         ` Konrad Rzeszutek Wilk
2010-04-09 14:21 ` [PATCH 2/2] ibft: For UEFI machines actually do scan ACPI for iBFT Konrad Rzeszutek Wilk
2010-04-21 21:29   ` Andrew Morton
2010-04-21 21:37     ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCF7037.9070301@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=akpm@linux-foundation.org \
    --cc=gpxe-devel@etherboot.org \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.